-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32U0: provide support for DAC peripherals #78108
STM32U0: provide support for DAC peripherals #78108
Conversation
6c9f549
to
d4dadfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only got minor comments.
Can you please squash the last commit into the second one, so that the docs are updated together with the board .dts
file?
d4dadfd
to
5823abe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last catch otherwise LGTM, thanks
e14b416
5823abe
to
e14b416
Compare
e15e717
e14b416
to
e15e717
Compare
e15e717
to
69c8095
Compare
@djiatsaf-st To fix the issue of tests overflowing soc footprint, don't hesitate to add |
69c8095
to
a58346c
Compare
all stm32u0 boards have only one and same dac peripheral. Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
a58346c
to
e1b2ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor non-blocking details:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that @mathieuchopstm identified the missing spaces, let's get all minor style issues fixed for consistency. Afterwards it's definitely ready.
-enable dac in nucleo_u031r8, stm32u083c_dk and nucleo_u083rc - add dac as new supported interface in docs - update yaml files Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
-add nucleo_u083rc and stm32u083c_dk boards for testbench purpose. - add min_ram property to skip test on boards with little ram size. Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
4018fd3
e1b2ed4
to
4018fd3
Compare
This PR adds digital to analog converter (DAC) peripherals on the stm32U0 boards.