Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32U0: provide support for DAC peripherals #78108

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

djiatsaf-st
Copy link
Collaborator

This PR adds digital to analog converter (DAC) peripherals on the stm32U0 boards.

tests/drivers/dac/dac_api/src/test_dac.c Outdated Show resolved Hide resolved
boards/st/nucleo_u031r8/nucleo_u031r8.dts Outdated Show resolved Hide resolved
@djiatsaf-st djiatsaf-st force-pushed the add_DAC_stm32u0 branch 2 times, most recently from 6c9f549 to d4dadfd Compare September 9, 2024 09:42
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only got minor comments.

Can you please squash the last commit into the second one, so that the docs are updated together with the board .dts file?

tests/drivers/dac/dac_api/src/test_dac.c Outdated Show resolved Hide resolved
martinjaeger
martinjaeger previously approved these changes Sep 9, 2024
gautierg-st
gautierg-st previously approved these changes Sep 9, 2024
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last catch otherwise LGTM, thanks

boards/st/nucleo_u031r8/doc/index.rst Outdated Show resolved Hide resolved
martinjaeger
martinjaeger previously approved these changes Sep 10, 2024
erwango
erwango previously approved these changes Sep 10, 2024
martinjaeger
martinjaeger previously approved these changes Sep 10, 2024
@erwango
Copy link
Member

erwango commented Sep 11, 2024

@djiatsaf-st To fix the issue of tests overflowing soc footprint, don't hesitate to add min_ram: <xx> to impacted test cases yaml files. This will be helpful for others as well.

gautierg-st
gautierg-st previously approved these changes Sep 11, 2024
all stm32u0 boards have only one and same
dac peripheral.

Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
erwango
erwango previously approved these changes Sep 12, 2024
marwaiehm-st
marwaiehm-st previously approved these changes Sep 12, 2024
gautierg-st
gautierg-st previously approved these changes Sep 13, 2024
mathieuchopstm
mathieuchopstm previously approved these changes Sep 13, 2024
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor non-blocking details:

boards/st/nucleo_u031r8/nucleo_u031r8.dts Outdated Show resolved Hide resolved
boards/st/nucleo_u083rc/nucleo_u083rc.dts Outdated Show resolved Hide resolved
boards/st/stm32u083c_dk/stm32u083c_dk.dts Outdated Show resolved Hide resolved
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that @mathieuchopstm identified the missing spaces, let's get all minor style issues fixed for consistency. Afterwards it's definitely ready.

boards/st/nucleo_u083rc/nucleo_u083rc.dts Outdated Show resolved Hide resolved
-enable dac in nucleo_u031r8, stm32u083c_dk and nucleo_u083rc
- add dac as new supported interface in docs
- update yaml files

Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
-add nucleo_u083rc and stm32u083c_dk  boards for testbench purpose.
- add min_ram property to skip test on boards with little ram size.

Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
@carlescufi carlescufi merged commit f7ebd61 into zephyrproject-rtos:main Sep 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DAC Digital-to-Analog Converter platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants