Bluetooth: Channel Sounding: Add bt_cs_set_default_settings
#78224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new controller and host kconfigs for Bluetooth 6.0 Channel Sounding. Signed-off-by: Sean Madigan <sean.madigan@nordicsemi.no>
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
3 times, most recently
from
0b93c5c
to
2af5b8a
Compare
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
from
2af5b8a
to
370fa2c
Compare
|
I would slightly prefer channel_sounding.c and channel_sounding.h over acronyms. I think that's a bit nicer for people who are less familiar, or browsing the code casually Feel free to leave it as is |
I may leave as is, I think cs will be a useful acronym to use |
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
2 times, most recently
from
61ca298
to
39212d5
Compare
zephyrbot
requested review from
alwa-nordic,
carlescufi,
cvinayak,
hermabe,
jhedberg,
jori-nordic,
kruithofa,
mtpr-ot,
sjanc,
Thalley,
theob-pro and
thoh-ot
olivier-le-sage
approved these changes
Sep 11, 2024
theob-pro
reviewed
Sep 11, 2024
theob-pro
requested changes
Sep 11, 2024
alwa-nordic
changed the title
bt_cs_set_default_settings
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
from
39212d5
to
f16cc67
Compare
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
from
f16cc67
to
956cf6b
Compare
theob-pro
previously approved these changes
Sep 11, 2024
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
from
956cf6b
to
0880632
Compare
theob-pro
previously approved these changes
Sep 12, 2024
olivier-le-sage
suggested changes
Sep 12, 2024
Added support for a new API for setting default channel sounding settings, this is mainly a wrapper around the HCI command. For this add a new module for channel sounding, where new channel sounding APIs will go. Signed-off-by: Sean Madigan <sean.madigan@nordicsemi.no>
Use a new file and command for this where all CS commands can live. Added support for bt_cs_set_default_settings command. Added test case where shell is built with CS to ensure code is built in CI. Signed-off-by: Sean Madigan <sean.madigan@nordicsemi.no>
sean-madigan
force-pushed
the
bt_cs_set_default_settings
branch
from
0880632
to
15f8bf0
Compare
olivier-le-sage
approved these changes
Sep 13, 2024
bugo-nordic
approved these changes
Sep 13, 2024
theob-pro
approved these changes
Sep 13, 2024
jori-nordic
approved these changes
Sep 16, 2024
jhedberg
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CS set default settings command for the host, along with kconfig and shell support.