Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intel: ACE: move hpsram_mask to a data section #78283

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Intel: ACE: move hpsram_mask to a data section #78283

merged 1 commit into from
Sep 16, 2024

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented Sep 11, 2024

On platforms with enforced memory access modes, .text is read-only. Move hpsram_mask to a cached data section to fix PTL.

@lyakh
Intel: ACE: move hpsram_mask to a data section
1b87e6f 
On platforms with enforced memory access modes, .text is read-only.
Move hpsram_mask to a cached data section to fix PTL.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh lyakh marked this pull request as ready for review September 12, 2024 07:00
@zephyrbot zephyrbot added the platform: Intel ADSP Intel Audio platforms label Sep 12, 2024
@lyakh
Copy link
Collaborator Author

lyakh commented Sep 12, 2024

I received a positive feedback about this on PTL, but we still need to test this on MTL which we currently cannot use the CI for due to a recent build regression

@lyakh lyakh added DNM This PR should not be merged (Do Not Merge) and removed DNM This PR should not be merged (Do Not Merge) labels Sep 12, 2024
@tmleman
Copy link
Collaborator

tmleman commented Sep 12, 2024

I proposed an alternative solution: #78342

@lyakh
Copy link
Collaborator Author

lyakh commented Sep 12, 2024

Tested by

I received a positive feedback about this on PTL, but we still need to test this on MTL which we currently cannot use the CI for due to a recent build regression

MTL testing successful too thesofproject/sof#9465

tmleman
tmleman approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the issue takes priority over the refactor. Merging this will allow testing PRs with SOF CI, and my changes can be tested and reviewed without time pressure.
@lyakh thx for fix.

@aescolar aescolar merged commit 1dde706 into zephyrproject-rtos:main Sep 16, 2024
29 of 30 checks passed
@lyakh lyakh deleted the hpsram branch September 16, 2024 08:03
@lyakh lyakh mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmleman tmleman tmleman approved these changes

@dcpleung dcpleung dcpleung approved these changes

@nashif nashif nashif approved these changes

@teburd teburd teburd approved these changes

@andyross andyross Awaiting requested review from andyross

@ceolin ceolin Awaiting requested review from ceolin

@jxstelter jxstelter Awaiting requested review from jxstelter

@kv2019i kv2019i Awaiting requested review from kv2019i

@lgirdwood lgirdwood Awaiting requested review from lgirdwood

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski

@softwarecki softwarecki Awaiting requested review from softwarecki

Assignees

@dcpleung dcpleung

Labels
platform: Intel ADSP Intel Audio platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lyakh @tmleman @teburd @nashif @dcpleung @zephyrbot @aescolar