Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support dspi for s32z270dc2 board #78314

Conversation

tunguyen4585
Copy link
Contributor

@tunguyen4585 tunguyen4585 commented Sep 12, 2024

This PR to support dspi by re-using mcux driver on s32z27xx devices
Tested on tests\drivers\spi\spi_loopback\drivers.spi.s32z_dspi.loopback
TESTSUITE spi_loopback succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [spi_loopback]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.366 seconds

  • PASS - [spi_loopback.test_spi_loopback] duration = 0.366 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 12, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@4597b16 zephyrproject-rtos/hal_nxp@683c007 (master) zephyrproject-rtos/hal_nxp@4597b16c..683c007c

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Sep 12, 2024
@tunguyen4585 tunguyen4585 force-pushed the support-dspi-for-s32z-2.0.0 branch 3 times, most recently from 0792a06 to 4218282 Compare September 12, 2024 16:27
Copy link
Member

@manuargue manuargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commits order must be improved:

  1. support for pinctrl LVDS pads
  2. DSPI support + west updates
  3. test enablement

dts/bindings/pinctrl/nxp,s32ze-pinctrl.yaml Outdated Show resolved Hide resolved
dts/bindings/pinctrl/nxp,s32ze-pinctrl.yaml Outdated Show resolved Hide resolved
soc/nxp/s32/s32ze/soc.h Outdated Show resolved Hide resolved
dts/bindings/pinctrl/nxp,s32ze-pinctrl.yaml Outdated Show resolved Hide resolved
@tunguyen4585 tunguyen4585 force-pushed the support-dspi-for-s32z-2.0.0 branch 2 times, most recently from b1e5f82 to caf6cf8 Compare September 22, 2024 14:00
@manuargue manuargue changed the title Add support dspi for s32z 2.0.0 Add support dspi for s32z270dc2 board Sep 23, 2024
@tunguyen4585 tunguyen4585 force-pushed the support-dspi-for-s32z-2.0.0 branch 4 times, most recently from 1f1fb44 to d79ed6e Compare September 26, 2024 04:14
Dat-NguyenDuy
Dat-NguyenDuy previously approved these changes Sep 27, 2024
manuargue
manuargue previously approved these changes Sep 27, 2024
@tunguyen4585
Copy link
Contributor Author

Hi @tbursztyka pls help me review this PR

@tunguyen4585
Copy link
Contributor Author

Hi @tbursztyka, a week passed, pls help me review this PR, thanks

@manuargue manuargue added this to the v4.0.0 milestone Oct 9, 2024
manuargue
manuargue previously approved these changes Oct 9, 2024
Dat-NguyenDuy
Dat-NguyenDuy previously approved these changes Oct 9, 2024
dleach02
dleach02 previously approved these changes Oct 9, 2024
@dleach02
Copy link
Member

@tbursztyka I've added @manuargue (NXP S32 platform maintainer) as a co-assignee so we can get this PR moving for 4.0

@manuargue
Copy link
Member

manuargue commented Oct 18, 2024

@tunguyen4585 HAL pr merged, please rebase & update manifest to 683c007c3b834012358b4adf96a532d18ce05646.
Because of the HAL merge order, after #78368 is merged I will reapprove this one.

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 18, 2024
@manuargue
Copy link
Member

@tunguyen4585 pls rebase again :)

support the configurations which apply for LVDS pads
+ termination resistor
+ current reference control
+ rx current boost

Signed-off-by: Tu Nguyen Van <tu.nguyenvan@nxp.com>
add dspi support for S32Z27x devices

Signed-off-by: Tu Nguyen Van <tu.nguyenvan@nxp.com>
enable test spi_loopback for dspi feature on s32z27x
devices

Signed-off-by: Tu Nguyen Van <tu.nguyenvan@nxp.com>
@henrikbrixandersen henrikbrixandersen merged commit 55bcc4a into zephyrproject-rtos:main Oct 21, 2024
25 checks passed
@manuargue manuargue deleted the support-dspi-for-s32z-2.0.0 branch October 21, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants