X86 compatibles #78483
Open
X86 compatibles #78483
+33
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiotrZierhoffer
force-pushed
the
x86-compatibles
branch
from
a433394
to
29b3ff7
Compare
mateusz-holenko
force-pushed
the
x86-compatibles
branch
from
29b3ff7
to
d7f4553
Compare
josuah
added
area: X86
mateusz-holenko
force-pushed
the
x86-compatibles
branch
2 times, most recently
from
e533b72
to
047123c
Compare
zephyrbot
requested review from
ceolin,
dcpleung,
edersondisouza,
kwd-doodling,
najumon1980,
nashif and
teburd
mateusz-holenko
force-pushed
the
x86-compatibles
branch
from
047123c
to
8b34579
Compare
atom.dtsi enforces "intel,x86", but it doesn't help us discern if the platform is 32 or 64-bit. We do that for example in RISC-V and it's useful from the tooling perspective. Signed-off-by: Piotr Zierhoffer <pzierhoffer@antmicro.com> Signed-off-by: Mateusz Hołenko <mholenko@antmicro.com>
Those dtsi are a base for a range of 32-bit platforms. Setting this compatible makes it easier to distinguish all 32-bit x86 platforms. Signed-off-by: Piotr Zierhoffer <pzierhoffer@antmicro.com> Signed-off-by: Mateusz Hołenko <mholenko@antmicro.com> y
This will help distinguish 64 and 32-bit platforms by tooling, following the pattern visible in e.g. RISC-V. Signed-off-by: Piotr Zierhoffer <pzierhoffer@antmicro.com> Signed-off-by: Mateusz Hołenko <mholenko@antmicro.com>
mateusz-holenko
force-pushed
the
x86-compatibles
branch
from
8b34579
to
14a1768
Compare
|
Rebased to include fixes from #78937 and the CI is green now. @ceolin, @dcpleung, @edersondisouza or others - could you take a look? |
nashif
approved these changes
Oct 14, 2024
dcpleung
approved these changes
Oct 14, 2024
kwd-doodling
approved these changes
Oct 15, 2024
ceolin
approved these changes
Oct 15, 2024
|
@edersondisouza is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request unifies x86 and x86-64 targets by adding an explicit
compatiblenote to all platforms.These entries are not added on the same level in every case due to the organization of existing x86[-64] platforms which I didn't want to change.
This change should effectively just add data to existing platforms but not change their behavior.