drivers: mbox: mbox_esp32: fix mbox callback call #78517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlocaione,
LucasTambor,
marekmatej,
raffarost,
sylvioalves and
wmrsouza
uLipe
requested review from
LucasTambor,
marekmatej,
wmrsouza,
raffarost and
carlocaione
and removed request for
carlocaione,
marekmatej,
LucasTambor,
wmrsouza and
raffarost
|
Not sure why this was merged this way, fortunately my local copy had the correct code. |
|
Would you mind running clang-format in this file to fix the macro spaces? |
raffarost
reviewed
Sep 17, 2024
raffarost
previously approved these changes
Sep 17, 2024
uLipe
force-pushed
the
fix/esp32_mbox_callback
branch
from
46771d5
to
f5fcda3
Compare
Fixes the mailbox notification callback that was not being called from the ISR when the other side sends something. Signed-off-by: Felipe Neves <ryukokki.felipe@gmail.com>
uLipe
force-pushed
the
fix/esp32_mbox_callback
branch
from
f5fcda3
to
bbae8a5
Compare
|
@sylvioalves just run the clang-format, PTAL again. |
raffarost
approved these changes
Sep 17, 2024
|
@raffarost i think when this driver got merged, the priority properties and flags were not present in the upstream yet. |
sylvioalves
approved these changes
Sep 18, 2024
LucasTambor
approved these changes
Sep 18, 2024
marekmatej
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mailbox notification callback that was not being called from the ISR when the other side sends something.