tests: drivers: build_all: adc: Add spi-devices build test #78580
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `default y`, which is coupled with depends on DT_HAS_TI_ADS1112_ENABLED to link the settings with DeviceTree, which was missing, so I added it. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
add_devices_for_build_all_adc
branch
from
7d650c7
to
343ed68
Compare
Remove unused variables for suppress warnings Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
add_devices_for_build_all_adc
branch
from
343ed68
to
c264eb8
Compare
decsny
reviewed
Sep 20, 2024
There was a problem hiding this comment.
please make commit title more specific about this device
There was a problem hiding this comment.
Update done.
Thank you for your check.
decsny
reviewed
Sep 20, 2024
There was a problem hiding this comment.
please make commit title more specific about this device
soburi
force-pushed
the
add_devices_for_build_all_adc
branch
from
c264eb8
to
26a4608
Compare
soburi
force-pushed
the
add_devices_for_build_all_adc
branch
from
26a4608
to
e8cbb88
Compare
decsny
previously approved these changes
Sep 23, 2024
|
@anangl |
anangl
requested changes
Sep 26, 2024
| @@ -344,6 +344,13 @@ | |||
| #io-channel-cells = <1>; | |||
| }; | |||
| }; | |||
|
|
|||
| test_spi_tla2021: tla2021@20 { | |||
| compatible = "ti,tla2021"; | |||
There was a problem hiding this comment.
This is an I2C device, not an SPI one.
Add configuration for ti,tla2021 to enable build test. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
add_devices_for_build_all_adc
branch
from
e8cbb88
to
9bbaaf4
Compare
anangl
approved these changes
Sep 26, 2024
decsny
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build tests for following devices.
And ADS1112 was not enabled correctly, so I fixed it.