Feature/wifi nxp shim driver bug fixes

[fengming-ye]

Fix NXP Wi-Fi shim driver bugs.

cad63ab
drivers: wifi: nxp: fix soft AP auto start

Fix soft AP net iface auto up after init.
Set dormant off/on when soft AP start/stop, to align with STA.

Signed-off-by: Fengming Ye <frank.ye@nxp.com>

874f8a4
drivers: wifi: nxp: add cancel action wait ops

Add cancel action wait ops to cancel remain on channel after TX on
specific channel, in case we need to remain on another channel later.

Signed-off-by: Fengming Ye <frank.ye@nxp.com>

[jukkar]

Not sure why you had the 3rd commit ("fix code format"), seems totally pointless, the original code looks good.

[fengming-ye]

Not sure why you had the 3rd commit ("fix code format"), seems totally pointless, the original code looks good.

just clang-format it and resolve history code format. Because I'm having "Maybe you would like to run clang-format" auto comment. Not sure if I can ignore it.

Check notice on line 1783 in drivers/wifi/nxp/nxp_wifi_drv.c

"
GitHub Actions
/ Run compliance checks on patch series (PR)
You may want to run clang-format on this change

drivers/wifi/nxp/nxp_wifi_drv.c:1783

• .deinit = wifi_nxp_wpa_supp_dev_deinit,
• .scan2 = wifi_nxp_wpa_supp_scan2,
• .scan_abort = wifi_nxp_wpa_supp_scan_abort,
• .get_scan_results2 = wifi_nxp_wpa_supp_scan_results_get,
• .deauthenticate = wifi_nxp_wpa_supp_deauthenticate,
• .authenticate = wifi_nxp_wpa_supp_authenticate,
• .associate = wifi_nxp_wpa_supp_associate,
• .set_key = wifi_nxp_wpa_supp_set_key,
• .set_supp_port = wifi_nxp_wpa_supp_set_supp_port,
• .signal_poll = wifi_nxp_wpa_supp_signal_poll,
• .send_mlme = wifi_nxp_wpa_supp_send_mlme,
• .get_wiphy = wifi_nxp_wpa_supp_get_wiphy,
• .get_capa = wifi_nxp_wpa_supp_get_capa,
• .get_conn_info = wifi_nxp_wpa_supp_get_conn_info,
• .set_country = wifi_nxp_wpa_supp_set_country,
• .get_country = wifi_nxp_wpa_supp_get_country,

• .deinit = wifi_nxp_wpa_supp_dev_deinit,
• .scan2 = wifi_nxp_wpa_supp_scan2,
• .scan_abort = wifi_nxp_wpa_supp_scan_abort,
• .get_scan_results2 = wifi_nxp_wpa_supp_scan_results_get,
• .deauthenticate = wifi_nxp_wpa_supp_deauthenticate,
• .authenticate = wifi_nxp_wpa_supp_authenticate,
• .associate = wifi_nxp_wpa_supp_associate,
• .set_key = wifi_nxp_wpa_supp_set_key,
• .set_supp_port = wifi_nxp_wpa_supp_set_supp_port,
• .signal_poll = wifi_nxp_wpa_supp_signal_poll,
• .send_mlme = wifi_nxp_wpa_supp_send_mlme,
• .get_wiphy = wifi_nxp_wpa_supp_get_wiphy,
• .get_capa = wifi_nxp_wpa_supp_get_capa,
• .get_conn_info = wifi_nxp_wpa_supp_get_conn_info,
• .set_country = wifi_nxp_wpa_supp_set_country,
• .get_country = wifi_nxp_wpa_supp_get_country,
  #ifdef CONFIG_NXP_WIFI_SOFTAP_SUPPORT
  #ifdef CONFIG_WIFI_NM_HOSTAPD_AP

• .hapd_init = wifi_nxp_hostapd_dev_init,
• .hapd_deinit = wifi_nxp_hostapd_dev_deinit,
  -#endif
• .init_ap = wifi_nxp_wpa_supp_init_ap,
• .set_ap = wifi_nxp_hostapd_set_ap,
• .stop_ap = wifi_nxp_hostapd_stop_ap,
• .sta_remove = wifi_nxp_hostapd_sta_remove,
• .sta_add = wifi_nxp_hostapd_sta_add,
• .do_acs = wifi_nxp_hostapd_do_acs,
  -#endif
• .dpp_listen = wifi_nxp_wpa_dpp_listen,
• .remain_on_channel = wifi_nxp_wpa_supp_remain_on_channel,

• .hapd_init = wifi_nxp_hostapd_dev_init,
• .hapd_deinit = wifi_nxp_hostapd_dev_deinit,
  +#endif
• .init_ap = wifi_nxp_wpa_supp_init_ap,
• .set_ap = wifi_nxp_hostapd_set_ap,
• .stop_ap = wifi_nxp_hostapd_stop_ap,
• .sta_remove = wifi_nxp_hostapd_sta_remove,
• .sta_add = wifi_nxp_hostapd_sta_add,
• .do_acs = wifi_nxp_hostapd_do_acs,
  +#endif
• .dpp_listen = wifi_nxp_wpa_dpp_listen,
• .remain_on_channel = wifi_nxp_wpa_supp_remain_on_channel,
  .cancel_remain_on_channel = wifi_nxp_wpa_supp_cancel_remain_on_channel,

• .send_action_cancel_wait = wifi_nxp_wpa_supp_cancel_action_wait,

• .send_action_cancel_wait = wifi_nxp_wpa_supp_cancel_action_wait,
  "

[jukkar]

Those clang-format mentions can be ignored for now. Please remove the format commit from this pr.

[fengming-ye]

Those clang-format mentions can be ignored for now. Please remove the format commit from this pr.

ok updated

[fengming-ye]

@jukkar @dleach02 @danieldegrasse pls review and I believe it is an easy PR.
Because the commit is located in NXP driver. So I think as long as the code arch and format are okay, the functionality is verified and does not affect public Zephyr, it is okay.
Thanks.

[danieldegrasse]

Where is the implementation of this function? I don't see it within Zephyr or NXP's HAL

[fengming-ye]

zephyrproject-rtos/hal_nxp#416
it's in this PR.

[danieldegrasse]

Ok, so we need to make this PR dependent on zephyrproject-rtos/hal_nxp#416, then- otherwise this change is effectively adding dead code that can't be built (unless I'm missing something?)

[fengming-ye]

Hi @dleach02 @danieldegrasse
PR is rebased and build pass.
Pls help vote & merge. thanks.