Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mcumgr: Fix license #78923

Conversation

jeppenodgaard
Copy link
Collaborator

@jeppenodgaard jeppenodgaard commented Sep 24, 2024

mcumgr-client is Apache-2 and not BSD licensed.
See: https://github.com/vouch-opensource/mcumgr-client/blob/main/LICENSE

Fixes: #78927

mcumgr-client is Apache-2 and not BSD licensed. See:
https://github.com/vouch-opensource/mcumgr-client/blob/main/LICENSE

Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
@zephyrbot zephyrbot added area: mcumgr size: XS A PR changing only a single line of code labels Sep 24, 2024
nordicjm
nordicjm previously approved these changes Sep 24, 2024
@nordicjm nordicjm added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Sep 24, 2024
kartben
kartben previously approved these changes Sep 24, 2024
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the license say Apache-2.0?

@@ -55,7 +55,7 @@ project.
+================================================================================+=========+=======+=====+========+==========+========+===========+=====+====+=====+======+==========+====+=======+======+========+===============+============+=========+
| `AuTerm <https://github.com/thedjnK/AuTerm/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | Application | C++ (Qt) | GPLv3 |
+--------------------------------------------------------------------------------+---------+-------+-----+--------+----------+--------+-----------+-----+----+-----+------+----------+----+-------+------+--------+---------------+------------+---------+
| `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | BSD |
| `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | Apache |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | Apache |
| `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | Apache-2.0 |

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jeppenodgaard
Copy link
Collaborator Author

Shouldn't the license say Apache-2.0?

I do not know.

There's two other clients in the list that does not include the license version. I followed their example. The GPL license specifies the version, so the list is inconsistent. I guess that should be fixed.

Fix license notation inconsistency in the MCUmgr tools/libraries table.

Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
@jeppenodgaard jeppenodgaard dismissed stale reviews from kartben and nordicjm via 2b84670 September 26, 2024 13:39
@fabiobaltieri fabiobaltieri merged commit 6bca034 into zephyrproject-rtos:main Sep 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcumgr backport v3.6-branch Request backport to the v3.6-branch backport v3.7-branch Request backport to the v3.7-branch size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: mcumgr: Wrong license for mcumgr-client
7 participants