scripts: twister: Fix trailing CR/LF at BinaryHandler logs #78958
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golowanow
force-pushed
the
twister-fix-crlf-20240924
branch
from
be2f092
to
841a5da
Compare
Fix trailing `\\r\\n` (escaped CR/LF) didn't cut off because of rstrip() removed by zephyrproject-rtos#58338, so the CR/LF suffix was never found as the actual line end was `\\r\\n\n`. Add ANSI code sequence to `test_handlers` Twister unit test. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
golowanow
force-pushed
the
twister-fix-crlf-20240924
branch
from
841a5da
to
fb7c204
Compare
zephyrbot
requested review from
gchwier,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
keith-zephyr
approved these changes
Sep 25, 2024
nashif
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trailing
\\r\\n(escaped CR/LF) didn't cut off because ofrstrip()removed by #58338,so the CR/LF suffix was never found as the actual line end was
\\r\\n\n.Add ANSI code sequence to
test_handlersTwister unit test.// AFAIK, the issue should affect only Simics simulators.