Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: dns: Increase the size of dispatcher table #79056

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jukkar
Copy link
Member

@jukkar jukkar commented Sep 26, 2024

The dispatcher table needs to be large enough to have support for all file descriptor values.

Fixes #79042

pdgendt
pdgendt previously approved these changes Sep 26, 2024
rlubos
rlubos previously approved these changes Sep 26, 2024
The dispatcher table needs to be large enough to have support
for all file descriptor values.

Fixes zephyrproject-rtos#79042

Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Add CHECKIF() checks that verify that dispatcher table is
not overflowing.

Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
@jukkar jukkar dismissed stale reviews from rlubos and pdgendt via a9ea2e1 September 27, 2024 06:22
@jukkar jukkar force-pushed the fix/79042/dns-dispatcher-out-of-bounds branch from cc1e96d to a9ea2e1 Compare September 27, 2024 06:22
@jukkar
Copy link
Member Author

jukkar commented Sep 27, 2024

  • CI fixes
  • rebased to latest main

@zephyrbot zephyrbot added the area: Sockets Networking sockets label Sep 27, 2024
pdgendt
pdgendt previously approved these changes Sep 27, 2024
Make sure that CONFIG_ZVFS_OPEN_MAX in the tests and samples is at
least the same value as CONFIG_NET_SOCKETS_POLL_MAX so that we
cannot have more polled sockets than there are available file
descriptors.

Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
@jukkar
Copy link
Member Author

jukkar commented Sep 27, 2024

  • more tests and samples fixed in order to get CI to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net: dns: Out of bounds array access in DNS dispatcher
4 participants