Bluetooth: Controller: Fix multiple Extended Adv chain reception #79100
Conversation
Fix assertion when enabling simultaneous multiple Extended Advertising chain reception that is enabled by increasing supported auxiliary scan contexts. Supported auxiliary scan contexts can be increased using CONFIG_BT_CTLR_SCAN_AUX_SET value. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
zephyrbot
requested review from
carlescufi,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
|
@Tronil @jakkra This fix ensures that ULL is independently able to track and receive multiple interleaved Extended Advertising chains. Association of a Scan Aux context with parent Scan context is only maintained when using LLL scheduling between reception of ADV_EXT_IND and a scheduled reception of AUX_ADV_IND. The association is continued as long as continued LLL scheduling is used through the reception of rest of AUX_CHAIN_IND PDUs; the association is dropped when switching to ULL scheduling. |
| /* Reset Scan context association with any Aux context as a new | ||
| * extended advertising chain is being setup for reception here. | ||
| */ | ||
| lll->lll_aux = NULL; |
There was a problem hiding this comment.
if lll_aux is non-NULL before this, we don't need to do any cleanups or similar?
There was a problem hiding this comment.
No, this is just an association do that received PDUs are added to a linked list in the aux context. By setting it to NULL, a new aux context will get associated to which the new chain of PDUs will be added to the linked list.
| /* TODO: Would the reset of Scan context association with Aux | ||
| * context here interfere with LLL scheduling? May be LLL | ||
| * scheduling will gracefully stop further reception and release | ||
| * linked Rx buffers maintained in the Aux context? | ||
| * | ||
| * Is this code redundant/faulty here, now that Scan LLL and Aux | ||
| * ULL scheduling reset it anyway? | ||
| */ |
There was a problem hiding this comment.
This code has been here, and has not caused harm yet :-) .... the comment is here so that in case we faced the scenario that the question ask, then we know that this is the place to look for. CI is passing and a long duration manual test of running passive scanning with over 10 extended advertiser of ZLL and SDC application around seems stable for over couple hours.
Do not want to delete this code yet, unless i can get a failure due to this code. git blame will associate this comment with this commit and will help with thought process in case of future failure.
Fix assertion when enabling simultaneous multiple Extended Advertising chain reception that is enabled by increasing supported auxiliary scan contexts.
Supported auxiliary scan contexts can be increased using CONFIG_BT_CTLR_SCAN_AUX_SET value.
Fixes assertions like: