Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: dts: edtlib: minor design improvements #79133

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

scripts: dts: edtlib: minor design improvements #79133

wants to merge 4 commits into from
+82 −62

Conversation

fgrandel
Copy link
Contributor

@fgrandel fgrandel commented Sep 27, 2024 •
edited
Loading

This change set contains a few minor design improvements:

  • Some Node internals (even marked explicitly with an underscore) were accessed from outside the class.
  • A method contained all fields from the property spec in its signature rather than the prop spec itself.
  • Two type hints are added.
  • Fixed a minor glitch in the Property classdoc.

@fgrandel
scripts: dts: edtlib: improve Node encapsulation
8f5ff3d 
Moves several node-specific operations inside the Node class to improve
its encapsulation, remove a monkey patch and access to internal methods
and fields.

Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de>
@fgrandel
scripts: dts: edtlib: simplification
3058125 
Small refactorings to simplify code and improve method encapsulation.

Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de>
@fgrandel
scripts: dts: edtlib: type hints
5c539f3 
Adds type hints to functions that were not yet typed.

Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de>
@fgrandel
scripts: dts: edtlib: fix type docs
688a245 
The return type of 'uint8-array' properties was not yet documented.

Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak

@tejlmand tejlmand Awaiting requested review from tejlmand

At least 2 approving reviews are required to merge this pull request.

Assignees

@decsny decsny

Labels
area: Devicetree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgrandel @zephyrbot @decsny