Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ztest: Including the missing C standard library header #79136

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Ztest: Including the missing C standard library header #79136

merged 1 commit into from
Oct 8, 2024

Conversation

fsammoura1980
Copy link
Contributor

The ztest.c calls atoi, which is provided by the C standard library.

@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Testsuite Testsuite labels Sep 27, 2024
@github-actions GitHub Actions
Copy link

Hello @fsammoura1980, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nashif
nashif previously approved these changes Sep 28, 2024
View reviewed changes
aaronemassey
aaronemassey previously approved these changes Sep 30, 2024
View reviewed changes
niedzwiecki-dawid
niedzwiecki-dawid requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@niedzwiecki-dawid niedzwiecki-dawid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove #include <stdlib.h> which is under #ifdef CONFIG_ZTEST_SHUFFLE?

@fsammoura1980
Ztest: Including the missing C standard library header
8cc8904 
The ztest.c calls atoi, which is provided by the C standard library.
Remove the conditional inclusion of the C standard library with the
definition of CONFIG_ZTEST_SHUFFLE.

Signed-off-by: Firas Sammoura <fsammoura@google.com>
@fsammoura1980 fsammoura1980 dismissed stale reviews from aaronemassey and nashif via 8cc8904 October 2, 2024 17:17
fsammoura1980
fsammoura1980 commented Oct 2, 2024
View reviewed changes
Copy link
Contributor Author

@fsammoura1980 fsammoura1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

niedzwiecki-dawid
niedzwiecki-dawid approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@niedzwiecki-dawid niedzwiecki-dawid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nashif nashif merged commit 6f072ba into zephyrproject-rtos:main Oct 8, 2024
23 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Hi @fsammoura1980!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asemjonovs asemjonovs asemjonovs approved these changes

@niedzwiecki-dawid niedzwiecki-dawid niedzwiecki-dawid approved these changes

@aaronemassey aaronemassey aaronemassey approved these changes

@yperess yperess yperess approved these changes

@nashif nashif nashif approved these changes

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

Assignees

@nashif nashif

Labels
area: Testsuite Testsuite size: XS A PR changing only a single line of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fsammoura1980 @nashif @yperess @aaronemassey @niedzwiecki-dawid @asemjonovs @zephyrbot