Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: i3c: shell: fixup errors #79387

Merged

Conversation

XenuIsWatching
Copy link
Member

There were some copy and paste errors that were easily missed where the wrong print out would happen of an argument with info and an extra autocompelete would happen with the speed command.

dcpleung
dcpleung previously approved these changes Oct 3, 2024
gmarull
gmarull previously approved these changes Oct 4, 2024
@XenuIsWatching XenuIsWatching dismissed stale reviews from gmarull and dcpleung via b52dd37 October 4, 2024 19:20
dcpleung
dcpleung previously approved these changes Oct 4, 2024
dcpleung
dcpleung previously approved these changes Oct 7, 2024
@XenuIsWatching
Copy link
Member Author

rebasing to get away from the CI errors

dcpleung
dcpleung previously approved these changes Oct 8, 2024
There were some copy and paste errors that were easily missed where the
wrong print out would happen of an argument with `info` and an extra
autocompelete would happen with the `speed` command.

Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
A reference was missing for checking for null on devices.

Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Fix kconfig def for ibi where it is missing the CONFIG_.

Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Fix typos for enec/disec/rstact typos.

Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
There is the wrong argc count for the max ibi len for setmrl.

Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
@XenuIsWatching XenuIsWatching changed the title drivers: i3c: shell: fixup typos drivers: i3c: shell: fixup errors Oct 21, 2024
Copy link
Collaborator

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with either the shell or I3C areas, but all the issues here are possible to verify from a pure C programming level. Glad this could get fixed!

@MaureenHelm MaureenHelm merged commit 42da6c9 into zephyrproject-rtos:main Oct 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants