-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: i3c: shell: fixup errors #79387
Merged
MaureenHelm
merged 5 commits into
zephyrproject-rtos:main
from
XenuIsWatching:more-shell-fixes-i3c
Oct 21, 2024
Merged
drivers: i3c: shell: fixup errors #79387
MaureenHelm
merged 5 commits into
zephyrproject-rtos:main
from
XenuIsWatching:more-shell-fixes-i3c
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
previously approved these changes
Oct 3, 2024
gmarull
previously approved these changes
Oct 4, 2024
dcpleung
previously approved these changes
Oct 4, 2024
XenuIsWatching
force-pushed
the
more-shell-fixes-i3c
branch
from
October 7, 2024 16:27
bd33e2a
to
3b30a09
Compare
dcpleung
previously approved these changes
Oct 7, 2024
XenuIsWatching
force-pushed
the
more-shell-fixes-i3c
branch
2 times, most recently
from
October 8, 2024 00:05
736a578
to
267606d
Compare
rebasing to get away from the CI errors |
XenuIsWatching
force-pushed
the
more-shell-fixes-i3c
branch
from
October 8, 2024 17:19
267606d
to
7b9d89d
Compare
dcpleung
previously approved these changes
Oct 8, 2024
dcpleung
approved these changes
Oct 15, 2024
There were some copy and paste errors that were easily missed where the wrong print out would happen of an argument with `info` and an extra autocompelete would happen with the `speed` command. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
A reference was missing for checking for null on devices. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Fix kconfig def for ibi where it is missing the CONFIG_. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Fix typos for enec/disec/rstact typos. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
There is the wrong argc count for the max ibi len for setmrl. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
more-shell-fixes-i3c
branch
from
October 17, 2024 05:34
e2bd590
to
4096d61
Compare
XenuIsWatching
changed the title
drivers: i3c: shell: fixup typos
drivers: i3c: shell: fixup errors
Oct 21, 2024
josuah
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with either the shell or I3C areas, but all the issues here are possible to verify from a pure C programming level. Glad this could get fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some copy and paste errors that were easily missed where the wrong print out would happen of an argument with
info
and an extra autocompelete would happen with thespeed
command.