Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostap: add WPS PBC and PIN for AP mode #79540

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hostap: add WPS PBC and PIN for AP mode #79540

wants to merge 2 commits into from
+193 −4

Conversation

MaochenWang1
Copy link
Contributor

add WPS PBC and PIN for AP mode.

@MaochenWang1
Copy link
Contributor Author

Hi @jukkar @krish2718 please review

krish2718
krish2718 reviewed Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also maybe the file supp_api.c is becoming large, so, may be it's time to start adding supp_api_wps.c, supp_api_p2p.c etc?

modules/hostap/CMakeLists.txt Show resolved Hide resolved
include/zephyr/net/wifi_mgmt.h Outdated Show resolved Hide resolved
modules/hostap/src/supp_api.c Show resolved Hide resolved
krish2718
krish2718 previously approved these changes Oct 14, 2024
View reviewed changes
@MaochenWang1
Copy link
Contributor Author

MaochenWang1 commented Oct 15, 2024 •
edited
Loading

Hi @krish2718 @jukkar @dleach02 please review

@MaochenWang1
Copy link
Contributor Author

Hi @krish2718 @jukkar @dleach02 please review

krish2718
krish2718 previously approved these changes Oct 22, 2024
View reviewed changes
jukkar
jukkar previously approved these changes Oct 23, 2024
View reviewed changes
@henrikbrixandersen
Copy link
Member

Please rebase on main and resolve any merge conflicts.

@MaochenWang1 MaochenWang1 dismissed stale reviews from jukkar and krish2718 via 8060580 October 24, 2024 02:48
dleach02
dleach02 requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary hold until #79536 merges

@MaochenWang1
Copy link
Contributor Author

MaochenWang1 commented Oct 24, 2024 •
edited
Loading

Hi @krish2718 @jukkar @dleach02 fix the conflict, please review again

jukkar
jukkar previously approved these changes Oct 24, 2024
View reviewed changes
@MaochenWang1
Copy link
Contributor Author

MaochenWang1 commented Oct 25, 2024 •
edited
Loading

Hi @krish2718 @dleach02 please review again

krish2718
krish2718 previously approved these changes Oct 25, 2024
View reviewed changes
@MaochenWang1 MaochenWang1 dismissed stale reviews from krish2718 and jukkar via a17332b October 25, 2024 12:21
@MaochenWang1
Copy link
Contributor Author

Hi @krish2718 @jukkar @dleach02 fix the conflict, please review again

krish2718
krish2718 previously approved these changes Oct 25, 2024
View reviewed changes
jukkar
jukkar previously approved these changes Oct 25, 2024
View reviewed changes
@MaochenWang1
Copy link
Contributor Author

Hi @dleach02 please review and approve this

@MaochenWang1
Copy link
Contributor Author

Hi @henrikbrixandersen rebased and conflicts resolved, can you help review again?

@henrikbrixandersen
Copy link
Member

temporary hold until #79536 merges

#79536 was merged. Please take another look.

@MaochenWang1
Copy link
Contributor Author

Hi @henrikbrixandersen
David was worried that this PR may cause conflict on #79536, which is also from me and more urgent, so he commented on this.
Now since #79536 was merged, and I rebased and fixed the conflict, I think can go ahead and merge this PR. Thanks.

dleach02
dleach02 previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking PR merged

@dkalowsk dkalowsk added this to the v4.1.0 milestone Oct 28, 2024
@MaochenWang1
hostap: add WPS PBC and PIN for AP mode
254a73e 
add WPS PBC and PIN for AP mode.

Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
@MaochenWang1
hostap: use the correct config for EAP_SERVER
921e839 
Should use EAP_SERVER and EAP_SERVER_IDENTITY as the correct config,
for the AP WPS case.

Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
@MaochenWang1 MaochenWang1 dismissed stale reviews from dleach02, jukkar, and krish2718 via 921e839 October 31, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@rlubos rlubos Awaiting requested review from rlubos

@jukkar jukkar Awaiting requested review from jukkar

@krish2718 krish2718 Awaiting requested review from krish2718

@dleach02 dleach02 Awaiting requested review from dleach02

At least 2 approving reviews are required to merge this pull request.

Assignees

@jukkar jukkar

@krish2718 krish2718

Labels
area: Networking area: Samples Samples area: Wi-Fi Wi-Fi
Projects
Wi-Fi
Status: In Progress
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@MaochenWang1 @henrikbrixandersen @jukkar @dleach02 @krish2718 @dkalowsk @zephyrbot