Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.7-branch] drivers: touch: esp32: update driver support #79888

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

wmrsouza
Copy link
Collaborator

@wmrsouza wmrsouza commented Oct 15, 2024

touch_sensor support was lost when hal_espressif was updated to v5.1
The absence of .conf files enabling INPUT_ESP32_TOUCH_SENSOR incorrectly prevented the input_dump sample build process from failing due to missing required hal files.
This PR fixes the regression regarding to touch_sensor support lost on hal_espressif and adds the absent .conf files to the Espressif boards on the input_dump sample to avoid false positives

This PR is realate to the fix #79941 on main branch:

Fixes: #79947

@wmrsouza wmrsouza added the Backport Backport PR and backport failure issues label Oct 15, 2024
@zephyrbot zephyrbot added area: Input Input Subsystem and Drivers area: Samples Samples labels Oct 15, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 15, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@012f61c zephyrproject-rtos/hal_espressif@b562c44 (hal_v3.7-branch) zephyrproject-rtos/hal_espressif@012f61c5..b562c44c

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_espressif DNM This PR should not be merged (Do Not Merge) labels Oct 15, 2024
Update to fix regression regarding to touch_sensor on hal_espressif.

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
…ards

.conf files added to enable INPUT_ESP32_TOUCH_SENSOR during sample build.
The absence of these files incorrectly prevented the input_dump sample
build from failing due to missing required hal files.

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 16, 2024
@wmrsouza wmrsouza changed the title backport/touch sensor drivers: touch: esp32: update driver support Oct 16, 2024
@fabiobaltieri
Copy link
Member

Hi @wmrsouza, bakports should be handled using the backport bot whenever possible, that works by adding a backport tag to the original PR, the backport will be created automatically once the main PR is merged. I'll add that and to https://github.com/zephyrproject-rtos/zephyr/pull/79941/commits and close this for you.

@wmrsouza wmrsouza added the backport v3.7-branch Request backport to the v3.7-branch label Oct 16, 2024
@wmrsouza wmrsouza reopened this Oct 16, 2024
@wmrsouza
Copy link
Collaborator Author

@fabiobaltieri
The hal_espressif revision from this PR points to a different commit (in a different branch) that pointed by #79941, so I reopen this PR, remove backport v3.7-branch label from #79941 here and add this label here

@fabiobaltieri
Copy link
Member

@fabiobaltieri The hal_espressif revision from this PR points to a different commit (in a different branch) that pointed by #79941, so I reopen this PR, remove backport v3.7-branch label from #79941 here and add this label here

Oh sorry did not realize that, ok, still let's wait for the main PR to go in though.

@nashif nashif removed the backport v3.7-branch Request backport to the v3.7-branch label Oct 17, 2024
@sylvioalves sylvioalves changed the title drivers: touch: esp32: update driver support [v3.7-branch] drivers: touch: esp32: update driver support Oct 18, 2024
@sylvioalves sylvioalves added this to the v3.7.1 milestone Oct 18, 2024
@nashif nashif merged commit c69bea0 into zephyrproject-rtos:v3.7-branch Oct 18, 2024
56 of 61 checks passed
@wmrsouza wmrsouza deleted the backport/touch_sensor branch October 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Input Input Subsystem and Drivers area: Samples Samples Backport Backport PR and backport failure issues manifest manifest-hal_espressif
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants