drivers: regulator: API to get max regulator voltage #80029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelLaya
force-pushed
the
get_max_voltage
branch
2 times, most recently
from
cd1c094
to
203bdd8
Compare
RafaelLaya
changed the title
|
@gmarull @danieldegrasse @aasinclair Fixed title and commit message (this is on the regulator API, not i2c, but for some reason my brain made me type i2c...) Hope all the automatic tags are correct? |
gmarull
reviewed
Oct 18, 2024
RafaelLaya
force-pushed
the
get_max_voltage
branch
5 times, most recently
from
0a6696c
to
ecf18a1
Compare
Good point. I've added two more commits, for a total of three:
Now it's used in the tests Regarding for where this is needed:
|
gmarull
requested changes
Oct 21, 2024
There is already a get_min_voltage() API, so let us add an API to also query the max voltage Signed-off-by: Rafael Laya <rafael_laya97@hotmail.com.com>
RafaelLaya
force-pushed
the
get_max_voltage
branch
from
ecf18a1
to
956ea3b
Compare
added 2 commits
October 21, 2024 06:20
Adds unit tests to make sure get_max and get_min voltage remain healthy Signed-off-by: Rafael Laya <rafael_laya97@hotmail.com.com>
Linter pass makes CI happy and keeps code compliant with the stylistic guidelines of the project Signed-off-by: Rafael Laya <rafael_laya97@hotmail.com.com>
RafaelLaya
force-pushed
the
get_max_voltage
branch
from
956ea3b
to
996542d
Compare
Good catch! I thought I had three commits. My bad, now I've actually split the changes into the three commits mentioned above |
gmarull
approved these changes
Oct 24, 2024
fabiobaltieri
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a regulator_common_get_min_voltage() API, to query the maximum supported voltage on a regulator. This change adds an analogous and symmetric API to query the maximum supported voltage