net: sockets: socket_service: change callback arg to struct net_socket_service_event
#80041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove reference to async socket service Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
zephyrbot
added
area: Sockets
zephyrbot
requested review from
carlescufi,
dkalowsk,
jakub-uC,
jukkar,
kartben,
mmahadevan108,
pdgendt,
rlubos,
ssharks and
tbursztyka
as the async type got removed, there is only one type left, so no need to show that. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
optimize code for the net socket service. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
socket_service_remove_async
branch
from
b2abf3f
to
c24d87b
Compare
jukkar
reviewed
Oct 18, 2024
maass-hamburg
force-pushed
the
socket_service_remove_async
branch
2 times, most recently
from
d0b3990
to
4bd4999
Compare
jukkar
reviewed
Oct 18, 2024
maass-hamburg
force-pushed
the
socket_service_remove_async
branch
from
4bd4999
to
abdd26f
Compare
jukkar
previously approved these changes
Oct 18, 2024
pdgendt
previously approved these changes
Oct 18, 2024
maass-hamburg
force-pushed
the
socket_service_remove_async
branch
from
abdd26f
to
9a59f05
Compare
|
forgot to change it for the sample |
pdgendt
previously approved these changes
Oct 21, 2024
rlubos
reviewed
Oct 21, 2024
remove k_work related code and change the argument of the callback to `struct net_socket_service_event`. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
mention change of callback function for the socket service. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
socket_service_remove_async
branch
from
9a59f05
to
97aa0e6
Compare
rlubos
approved these changes
Oct 23, 2024
pdgendt
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remains from when there was a async mode for the socket service.
Mainly it changes the callback argument from
struct k_work *worktostruct net_socket_service_event.