nrfbsim: Provide a few updated to enable more apps #80145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with native_simulator's upstream main 51b27b67addd0073dc86e3d83f492c5cac5c3361 Which includes: * 51b27b nsi_utils: Add macro for weak declarations Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
zephyrbot
added
area: native port
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
hermabe
previously approved these changes
Oct 21, 2024
|
CC @ilhanates |
aescolar
force-pushed
the
nrfbsim_system
branch
from
3ce40ae
to
7c95469
Compare
Update the HW models module to: aca798cf7cf0c5dc1fd89c66cf62670051feb8d0 Including the following: * aca798c IRQ controller: Add missing prototype * 4f108bc IRQ controller: Add API to check if int is pending * a514448 MDK: provide replacement for SystemCoreClock* Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Some apps use it, so let's provide it. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Add a substitute for NVIC_GetPendingIRQ() Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
force-pushed
the
nrfbsim_system
branch
from
7c95469
to
8815ba8
Compare
hermabe
approved these changes
Oct 22, 2024
alexsven
approved these changes
Oct 22, 2024
rugeGerritsen
approved these changes
Oct 22, 2024
cvinayak
previously requested changes
Oct 23, 2024
| @@ -18,6 +18,7 @@ void nrfbsim_WFE_model(void); | |||
| void nrfbsim_SEV_model(void); | |||
|
|
|||
| #define IRQ_ZERO_LATENCY BIT(1) /* Unused in this board*/ | |||
| #define IRQ_PRIO_LOWEST UINT8_MAX | |||
There was a problem hiding this comment.
Suggested change
| #define IRQ_PRIO_LOWEST UINT8_MAX | |
| #define IRQ_PRIO_LOWEST UINT8_MAX |
There was a problem hiding this comment.
you don't like the defines aligned? :)
There was a problem hiding this comment.
There is a tab, is it not? ... no. of spaces to align i can not make out in github, but definitely see a tab though.
There was a problem hiding this comment.
there is 2 tabs to align with the single tab in the line above
There was a problem hiding this comment.
Tab only allowed at the beginning of lines in Zephyr, atleast that is how compliance used to be.
cvinayak
dismissed
their stale review
authors descretion to fix tabs in between defines.
carlescufi
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor updates which enable more apps.
One commit provides a macro defined for ARM some apps need. The other 2 are minor updates to the native simulator and HW models.