Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sensor: wsen_pdus_25131308XXXXX: add sensor driver #80236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wm-eisos
Copy link
Contributor

@wm-eisos wm-eisos commented Oct 22, 2024

Add wsen_pdus_25131308XXXXX driver with the corrected name and compatibility with the hal update as well as added new features.

This PR is a continuation of the closed PR #62408

@henrikbrixandersen
@mah-eiSmart

Add wsen_pdus_25131308XXXXX driver with
the corrected name and compatibility with
the hal update as well as added new features..

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
Copy link
Contributor Author

@dkalowsk @ubieda can you check this one please?

@dkalowsk
Copy link
Contributor

dkalowsk commented Nov 4, 2024

I have to admit somehow I missed this notification until just now. Given that we're at RC2 this looks to be adding in support for a new device and that is usually not something the RCs allow. If you feel this needs to be in (say to fix an issue in 4.0), we can attach a GitHub issue, and likely bring this forward to the release team for review. Otherwise, are you okay with this being merged in for 4.1?

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Nov 4, 2024

I have to admit somehow I missed this notification until just now. Given that we're at RC2 this looks to be adding in support for a new device and that is usually not something the RCs allow. If you feel this needs to be in (say to fix an issue in 4.0), we can attach a GitHub issue, and likely bring this forward to the release team for review. Otherwise, are you okay with this being merged in for 4.1?

Hey Dan,

This PR was created due to the request from the reviewers to split up one big PR. And that PR removed an older bugged version of the driver and replaced it with this new driver. If this PR isnt merged in the release 4.0 that means that the older driver has been removed for no reason. so i believe this should be merged in the current release. You can also refer to the description of the PR to better understand the whole scenario.

Best Regards
Wajdi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants