pm: policy: modularize code, add latency standalone mode #80238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gmarull
commented
Oct 22, 2024
gmarull
commented
- Modularize code to improve reading/browsing functionality (no functional changes)
- Allow using latency API in standalone mode (see commit for more details)
policy.c has grown organically, it contained many independent pieces of code. This patch splits each logical unit into its own C file, making it easier to browse the code. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
This option allows using the pm_policy_latency* APIs to gather latency requirements on systems that do not support PM (e.g. systems whithout CPU idle states). Because the API has a subscription mechanism, it can be useful to perform system-level adjustments based on latency requirements gathered from multiple system components. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
zephyrbot
requested review from
ceolin,
JordanYates,
nashif,
teburd and
tmleman
|
Changes look good to me. Let wait CI runs and I will also do more checks later and look more carefully later, but it looks nice. Thanks. |
ceolin
approved these changes
Oct 23, 2024
bjarki-andreasen
approved these changes
Oct 23, 2024
tmleman
approved these changes
Oct 23, 2024
gmarull
added a commit
to gmarull/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
policy.c has grown organically, it contained many independent pieces of code. This patch splits each logical unit into its own C file, making it easier to browse the code. Upstream PR: zephyrproject-rtos/zephyr#80238 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit e2fb314d39c18a61815f44a01bee1483b2342d41)
gmarull
added a commit
to gmarull/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
This option allows using the pm_policy_latency* APIs to gather latency requirements on systems that do not support PM (e.g. systems whithout CPU idle states). Because the API has a subscription mechanism, it can be useful to perform system-level adjustments based on latency requirements gathered from multiple system components. Upstream PR: zephyrproject-rtos/zephyr#80238 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 766c88076259dfd458b0c09c9cd7236733a982aa)
gmarull
added a commit
to gmarull/sdk-zephyr
that referenced
this pull request
Oct 31, 2024
policy.c has grown organically, it contained many independent pieces of code. This patch splits each logical unit into its own C file, making it easier to browse the code. Upstream PR: zephyrproject-rtos/zephyr#80238 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit e2fb314d39c18a61815f44a01bee1483b2342d41)
gmarull
added a commit
to gmarull/sdk-zephyr
that referenced
this pull request
Oct 31, 2024
This option allows using the pm_policy_latency* APIs to gather latency requirements on systems that do not support PM (e.g. systems whithout CPU idle states). Because the API has a subscription mechanism, it can be useful to perform system-level adjustments based on latency requirements gathered from multiple system components. Upstream PR: zephyrproject-rtos/zephyr#80238 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 766c88076259dfd458b0c09c9cd7236733a982aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.