tests: debug/coredump: Change to call k_panic() for ISH SoCs #80269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
reviewed
Oct 23, 2024
ISH SoCs have zero-address memory mapped to I2C0 controller. Coredump cannot be triggered by zero-address access. Signed-off-by: Dong Wang <dong.d.wang@intel.com>
kwd-doodling
force-pushed
the
dwang4_core_dump_ish
branch
from
5b376d6
to
e23eae9
Compare
dcpleung
approved these changes
Oct 24, 2024
mrkhldn
approved these changes
Oct 24, 2024
|
@nashif , can you help take a look at this PR. |
nashif
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISH SoCs have zero-address memory mapped to I2C0 controller. Coredump cannot be triggered by zero-address access.
Fixes #79698