Add iopctl driver for RT 3 digital platforms #81086
Open
+128
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucien-nxp
commented
Nov 7, 2024
•
lucien-nxp
commented
- add new iopctl driver for RT 3 digital platforms
- use iopctl name as pin config IP in dts files for RT500/600
- adapt new driver for RT500/600
zephyrbot
added
area: Pinctrl
platform: NXP Drivers
zephyrbot
requested review from
butok,
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
EmilioCBen,
gmarull,
manuargue,
MarkWangChinese and
yvanderv
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
lucien-nxp
force-pushed
the
develop/change-pinctrl-model-for-RT3-digital-platforms
branch
2 times, most recently
from
2e45a34
to
eeb7a35
Compare
|
Hi @hakehuang, |
@Lucien-Zhao one issues found in testing. which is ok in v4.0-rc2 |
hakehuang
reviewed
Nov 8, 2024
gmarull
reviewed
Nov 8, 2024
drivers/pinctrl/pinctrl_iopctl.c
Outdated
Comment on lines
18
to
21
| #if DT_NUM_INST_STATUS_OKAY(DT_DRV_COMPAT) > 1 | ||
| (uint32_t *)DT_REG_ADDR(DT_NODELABEL(iopctl1)), | ||
| #endif | ||
| #if DT_NUM_INST_STATUS_OKAY(DT_DRV_COMPAT) > 2 |
There was a problem hiding this comment.
why not just check if node exists? this looks fragile
There was a problem hiding this comment.
Updated. Thank you.
There was a problem hiding this comment.
We may want to add a note in the migration guide for 4.1 that this binding has been renamed, and that the Kconfig for the RT500/RT600 pin control has changed to PINCTRL_NXP_IOPCTL from PINCTRL_NXP_IOCON
There was a problem hiding this comment.
Yes, which doc should I update? Could you tell me the file path?
There was a problem hiding this comment.
https://github.com/zephyrproject-rtos/zephyr/blob/main/doc/releases/migration-guide-4.1.rst#L1
Look at the migration guide for 4.0 to get an idea of what to add- you would place this under the "Device Drivers and Devicetree" section
There was a problem hiding this comment.
Thank you. Changes have been recorded in migration-guide-4.1.
lucien-nxp
force-pushed
the
develop/change-pinctrl-model-for-RT3-digital-platforms
branch
from
eeb7a35
to
1bfbe48
Compare
Hi @hakehuang , PASS - test_pm_singlethread in 2.288 secondsTESTSUITE power_mgmt succeeded ------ TESTSUITE SUMMARY START ------ SUITE PASS - 100.00% [power_mgmt]: pass = 3, fail = 0, skip = 0, total = 3 duration = 5.717 seconds
------ TESTSUITE SUMMARY END ------ =================================================================== |
|
Details log show below: |
lucien-nxp
force-pushed
the
develop/change-pinctrl-model-for-RT3-digital-platforms
branch
from
1bfbe48
to
b04ad88
Compare
|
@lucien-nxp ok, I find I need power cycle the board after flash to make this case pass. |
hakehuang
previously approved these changes
Nov 12, 2024
| int pinctrl_configure_pins(const pinctrl_soc_pin_t *pins, uint8_t pin_cnt, uintptr_t reg) | ||
| { | ||
| for (uint8_t i = 0; i < pin_cnt; i++) { | ||
| uint32_t pin_mux = pins[i]; |
There was a problem hiding this comment.
Do we need to have a mask here as well? It seems like we should not be writing all the bits of the pinmux setting, since the upper bits are used for the pin/offset
There was a problem hiding this comment.
Yes, I have added code to use masked value to write into iopctl register. Thank you.
lucien-nxp
force-pushed
the
develop/change-pinctrl-model-for-RT3-digital-platforms
branch
2 times, most recently
from
ef48459
to
dcf5c29
Compare
doc/releases/migration-guide-4.1.rst
Outdated
| @@ -39,6 +39,26 @@ LVGL | |||
| Device Drivers and Devicetree | |||
| ***************************** | |||
|
|
|||
| * The :dtcompatible:`nxp,lpc-iocon` and `nxp,rt-iocon-pinctrl` driver won't be used | |||
There was a problem hiding this comment.
Take a look at how dtcompatible is used in other examples (IE 4.0 release notes):
zephyr/doc/releases/migration-guide-4.0.rst
Line 121 in f7ff830
You need to enclose the old (unavailable) DT bindings in double backticks, like so:
``nxp,rt-iocon-pinctrl``
There was a problem hiding this comment.
Thank you for pointing out the issue. I have updated it in migration guide, thank you.
RT3 digital platforms won't reuse lpc_iocon driver, new iopctl driver have been developed for iopctl IP. Due to RT700 have multi iopctl instances, add code to handle the index value recorded in new pinctrl header file Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>
Change pin register name from iocon to iopctl Delete pin type mask macro, there is no need to add these macros to adapt iocon IP structure. Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>
track hal_nxp 460 PR Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>
lucien-nxp
force-pushed
the
develop/change-pinctrl-model-for-RT3-digital-platforms
branch
from
dcf5c29
to
0d357bb
Compare
This was referenced Nov 15, 2024
|
@lucien-nxp, @mmahadevan108 and I discussed internally and we think there might be value to continuing to use the existing IOCON driver, and updating the pin control data for LPC5* parts that use the IOCON driver as well. What are your thoughts on this approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.