tests: posix: common: separate posix xopen streams to standalone test #81445
+46
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
requested changes
Nov 15, 2024
|
|
||
| cmake_minimum_required(VERSION 3.20.0) | ||
| find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | ||
| project(posix_xopen_streams) |
There was a problem hiding this comment.
This should be xsi_streams to match the Open Group name which should presumably be XSI_STREAMS although the spec is not explicitly clear about that (the feature test macro is _XOPEN_STREAMS).
https://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap02.html
So please adjust the testsuite to use xsi_streams instead of posix_xopen_streams, including the directory name too.
Thanks!
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves stropts into a singular testsuite at tests/posix/xsi_streams app directory. Signed-off-by: Marvin Ouma <pancakesdeath@protonmail.com>
Pancakem
force-pushed
the
separate_posix_xopen_streams_to_standalone_test
branch
from
1287e47
to
26a057d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79454
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves stropts into a singular testsuite at tests/posix/xopen_streams app directory.