Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New norwegian translation #45

Merged
merged 5 commits into from
Oct 22, 2022
Merged

Conversation

tplive
Copy link
Contributor

@tplive tplive commented Oct 20, 2022

Celebrate Halloween in 🇳🇴 this year!

@zer0Kerbal zer0Kerbal self-requested a review October 20, 2022 15:48
@zer0Kerbal zer0Kerbal added type: localization related to localization and translations state: approved Approved to proceed. hacktoberfest-accepted flag for stating PR is accepted as appropriate for hacktoberfest labels Oct 20, 2022
@zer0Kerbal zer0Kerbal added this to the Localization - Master milestone Oct 20, 2022
@zer0Kerbal
Copy link
Owner

Celebrate Halloween in 🇳🇴 this year!

(He did the mash) He did the monster mash
(The monster mash) It was a graveyard smash
(He did the mash) It caught on in a flash
(He did the mash) He did the monster mash

(https://youtu.be/SOFCQ2bfmHw)

// ************** Halloween Candle
#HLWN-Candle-titl-s = Halloween-stearinlys (Lite)
#HLWN-Candle-titl-m = Halloween-stearinlys
#HLWN-Candle-titl-l = Halloween-stearinlys (Stor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stort?

Suggested change
#HLWN-Candle-titl-l = Halloween-stearinlys (Stor)
#HLWN-Candle-titl-l = Halloween-stearinlys (Stort)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boyum thank you for your input:

would lys (single rather than plural) be a better word for stearinlys?

?

liten = small(er than normal)
vanlig = normal in size (medium)
stør = big? (large)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lys" is both singular and plural. Because the word is neuter, "lite", "vanlig", and "stort" would be the correct translations for "small", "regular", and "large". Whether "regular"/"vanlig" is necessary is up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "lys" (here) means any kind of light source, rather than being just a "candle". So while "lys" is more terse, "stearinlys" is specific. If "stearinlys" doesn't fit the UI, or it's otherwise obvious that this is indeed a candle, then "lys" would be fine.

Copy link
Owner

@zer0Kerbal zer0Kerbal Oct 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you both @tplive and @boyum !

It is so wonderful to see this conversation.

stearinlys it is.

vanlig is not really needed since it is the 'normal' :D

🎃

@zer0Kerbal zer0Kerbal requested a review from boyum October 21, 2022 03:49
tplive and others added 2 commits October 21, 2022 07:53
Fixes typo

Co-authored-by: Sindre Bøyum <boyum@users.noreply.github.com>
Signed-off-by: Thomas Qvidahl <thomas@qvidahl.no>
Fixes typo

Co-authored-by: Sindre Bøyum <boyum@users.noreply.github.com>
Signed-off-by: Thomas Qvidahl <thomas@qvidahl.no>
GameData/Halloween/Localization/no-no.cfg Outdated Show resolved Hide resolved
// ************** Halloween Candle
#HLWN-Candle-titl-s = Halloween-stearinlys (Lite)
#HLWN-Candle-titl-m = Halloween-stearinlys
#HLWN-Candle-titl-l = Halloween-stearinlys (Stor)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boyum thank you for your input:

would lys (single rather than plural) be a better word for stearinlys?

?

liten = small(er than normal)
vanlig = normal in size (medium)
stør = big? (large)

What can I say... it's been a rough week..

Co-authored-by: zer0Kerbal <39887717+zer0Kerbal@users.noreply.github.com>
Signed-off-by: Thomas Qvidahl <thomas@qvidahl.no>
"Lengre" looks more correct in this context, from what I can see from The Norwegian Language Council's explanation.. Thanks again @boyum! <3

Co-authored-by: Sindre Bøyum <boyum@users.noreply.github.com>
Signed-off-by: Thomas Qvidahl <thomas@qvidahl.no>
@zer0Kerbal zer0Kerbal changed the base branch from master to 1.0.0.1-release October 22, 2022 02:15
@zer0Kerbal
Copy link
Owner

@tplive I've am unable to add @boyum to the assignees for credit.

@zer0Kerbal zer0Kerbal merged commit f8f824c into zer0Kerbal:1.0.0.1-release Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted flag for stating PR is accepted as appropriate for hacktoberfest state: approved Approved to proceed. type: localization related to localization and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization - Master Localization - Norwegian (Norsk) <no-no.cfg>
3 participants