Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to terminate SbDut #256

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Add method to terminate SbDut #256

merged 5 commits into from
Aug 20, 2024

Conversation

azaidy
Copy link
Collaborator

@azaidy azaidy commented Aug 20, 2024

No description provided.

@azaidy azaidy requested a review from gadfort August 20, 2024 03:29
@azaidy
Copy link
Collaborator Author

azaidy commented Aug 20, 2024

Simply reusing code that exists here for a new terminate method.

gadfort
gadfort requested changes Aug 20, 2024
View reviewed changes
switchboard/sbdut.py Outdated Show resolved Hide resolved
switchboard/sbdut.py Show resolved Hide resolved
gadfort
gadfort approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@gadfort gadfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azaidy azaidy marked this pull request as ready for review August 20, 2024 22:02
@azaidy azaidy merged commit eb797f9 into main Aug 20, 2024
6 checks passed
@azaidy azaidy deleted the ali/sbdut-term branch August 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadfort gadfort gadfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azaidy @gadfort