Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade packages, Use typescript #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade packages, Use typescript #49

wants to merge 2 commits into from

Conversation

leoj3n
Copy link
Contributor

@leoj3n leoj3n commented Mar 13, 2024

Everything should work here except the dark theme for the website seems to no longer be applied.

@leoj3n leoj3n changed the title Upgrade packages Upgrade packages, Use typescript Mar 13, 2024
@leoj3n
Copy link
Contributor Author

leoj3n commented Mar 13, 2024 •
edited
Loading

IntelliSense in action

  • Img hover:

image

  • CTRL+SPACE

image

  • src hover:

image

@leoj3n leoj3n force-pushed the upgrade-packages branch from 4567296 to 2c06682 Compare March 14, 2024 00:22
@zerodevx
Copy link
Owner

In theory, js with jsdoc definitions should work just fine since svelte-package promises to generate ts.ds from them (so intellisense should be somewhat functional). The problem is it under-delivers. IBM does a better job with sveld so we use that instead.

Really appreciate your PR though! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoj3n @zerodevx