Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ping text from sendPing instead of binary payload from websocket #189

Closed
wants to merge 9 commits into from
Closed

fix: remove ping text from sendPing instead of binary payload from websocket #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
924490b
feat: remove enum32 deps from install require
ranjanrak Jul 16, 2021
14b8017
upgrade version to v4.2.0
vividvilla Jan 9, 2023
f9469a5
feat: add virtual contract note API
ranjanrak Jul 31, 2023
4153268
chore: remove CI support for py 2.7
ranjanrak Jul 31, 2023
faf8dd8
feat: update version and readme for 5.0.0-beta release
ranjanrak Jul 31, 2023
ca30894
Update version to v5.0.0
vividvilla Oct 16, 2023
be7e02e
fix: remove ping text from sendPing instead of binary
ranjanrak Feb 7, 2024
9f7d42d
fix: downgrade urllib3 version to support openSSL in workflow
ranjanrak Feb 7, 2024
e562664
Merge branch 'master' of https://github.com/ranjanrak/pykiteconnect i…
ranjanrak Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ responses>=0.12.1
pytest-cov>=2.10.1
flake8>=3.8.4, <= 4.0.1
mock>=3.0.5
urllib3<2.0
4 changes: 0 additions & 4 deletions kiteconnect/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class KiteTickerClientProtocol(WebSocketClientProtocol):
PING_INTERVAL = 2.5
KEEPALIVE_INTERVAL = 5

_ping_message = ""
_next_ping = None
_next_pong_check = None
_last_pong_time = None
Expand Down Expand Up @@ -107,14 +106,11 @@ def onPong(self, response): # noqa
def _loop_ping(self): # noqa
"""Start a ping loop where it sends ping message every X seconds."""
if self.factory.debug:
log.debug("ping => {}".format(self._ping_message))
if self._last_ping_time:
log.debug("last ping was {} seconds back.".format(time.time() - self._last_ping_time))

# Set current time as last ping time
self._last_ping_time = time.time()
# Send a ping message to server
self.sendPing(self._ping_message)

# Call self after X seconds
self._next_ping = self.factory.reactor.callLater(self.PING_INTERVAL, self._loop_ping)
Expand Down
Loading