Skip to content
This repository has been archived by the owner on Jun 5, 2018. It is now read-only.

Minor enhancements for compilations #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

achims311
Copy link
Contributor

Hi,

I think I've got some minor enhancements for compilation processing.

  • compilation detection get case insensitive
  • better numbering for compilations with more than 100 tracks

Achim

@ghost ghost assigned zerodogg Sep 24, 2013
@zerodogg
Copy link
Owner

Hi,
thanks for the pull request!

First off, wrt. the compliation detection. The currently available combination of either --consistent and --compilation or --insensitive and --compilation doesn't do what you want it to? If so, this should probably be added as an option (--icompilation or similar) instead of enforcing it on everything.

A dry run mode would probably be useful, but your solution needs a bit more work, for instance should a dry run mode never update the cache (and there are calls to addToCache that might need to be skipped. Then again it might be just as easy to simply skip writeCache() when in dry-run mode).

Track-numbering for albums with >=100 tracks looks good, except for minor code style changes (line 1208, the { should be on a line by itself).

Would you mind opening up separate pull requests for each of the features (commit to feature branches perhaps)? Compilation and dry run needs a tad more work, but track numbering is almost mergeable already, with the minor tweak mentioned above.

@achims311
Copy link
Contributor Author

Hi,

fine.
So I'll suggest to start getting the dryrun implemented.
As this helps me for testing :-)

I'll close this pull request, and open another one just for the dryrun, as soon as ready.
I'll do this in a "dryrun" branch. (I'm new to git, so I try my best here..)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants