gltfpack: Add support for EXT_texture_webp #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently pending a merge to upstream: jkuhlmann/cgltf#253
Similarly to KHR_texture_basisu appearing in the input, we now preserve webp images along with the extension if they are present in the input file.
We only need an implementation for hasTransparency as getDimensions is only needed by texture compression pipeline which doesn't support anything but PNG/JPEG as an input.
The implementations have been written based on Wikipedia for PNG/JPEG, official Khronos specification for KTX2 and Google's specification for WebP.
We don't support encoding webp images but we will now preserve them if they occur in the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to KHR_texture_basisu appearing in the input, we now preserve
WebP images along with the extension if they are present in the input
file. There is no support for encoding them if the input file uses PNG/JPEG
(nor will there be).
Relies on jkuhlmann/cgltf#253 for parsing.
Fixes #536.