-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
9 changed files
with
163 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
*.js | ||
*.d.ts | ||
*.test.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
## Git Commit Message Convention | ||
|
||
> This is adapted from [Angular's commit convention](https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-angular). | ||
#### TL;DR: | ||
|
||
Messages must be matched by the following regex: | ||
|
||
```js | ||
/^(revert: )?(feat|fix|docs|dx|style|refactor|perf|test|workflow|build|ci|chore|types|wip)(\(.+\))?: .+/; | ||
``` | ||
|
||
#### Examples | ||
|
||
Appears under "Features" header, `avformat` subheader: | ||
|
||
``` | ||
feat(avformat): add 'IMp4Format' feature | ||
``` | ||
|
||
Appears under "Bug Fixes" header, `avcodec` subheader, with a link to issue #00: | ||
|
||
``` | ||
fix(avcodec): when stop reset subTaskId and subtitleTaskId | ||
close #00 | ||
``` | ||
|
||
Appears under "Performance Improvements" header, and under "Breaking Changes" with the breaking change explanation: | ||
|
||
``` | ||
perf(avrender): improve performance by utilizing WebGL | ||
BREAKING CHANGE: The performance enhancement now relies on WebGL. | ||
``` | ||
|
||
The following commit and commit `667ecc1` do not appear in the changelog if they are under the same release. If not, the revert commit appears under the "Reverts" header. | ||
|
||
``` | ||
revert: feat(avutil): add 'av1syntax' feature | ||
This reverts commit 667ecc1654a317a13331b17617d973392f415f02. | ||
``` | ||
|
||
### Full Message Format | ||
|
||
A commit message consists of a **header**, **body** and **footer**. The header has a **type**, **scope** and **subject**: | ||
|
||
``` | ||
<type>(<scope>): <subject> | ||
<BLANK LINE> | ||
<body> | ||
<BLANK LINE> | ||
<footer> | ||
``` | ||
|
||
The **header** is mandatory and the **scope** of the header is optional. | ||
|
||
### Revert | ||
|
||
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. In the body, it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted. | ||
|
||
### Type | ||
|
||
If the prefix is `feat`, `fix` or `perf`, it will appear in the changelog. However, if there is any [BREAKING CHANGE](#footer), the commit will always appear in the changelog. | ||
|
||
Other prefixes are up to your discretion. Suggested prefixes are `docs`, `chore`, `style`, `refactor`, and `test` for non-changelog related tasks. | ||
|
||
### Scope | ||
|
||
The scope could be anything specifying the place of the commit change. For example `avformat`, `avcodec`, `avutil`, `avrender`, `avnetwork` etc... | ||
|
||
### Subject | ||
|
||
The subject contains a succinct description of the change: | ||
|
||
- use the imperative, present tense: "change" not "changed" nor "changes" | ||
- don't capitalize the first letter | ||
- no dot (.) at the end | ||
|
||
### Body | ||
|
||
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes". | ||
The body should include the motivation for the change and contrast this with previous behavior. | ||
|
||
### Footer | ||
|
||
The footer should contain any information about **Breaking Changes** and is also the place to | ||
reference GitHub issues that this commit **Closes**. | ||
|
||
**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
const { execSync, spawnSync } = require('child_process'); | ||
|
||
const modifiedList = execSync('git diff --cached --name-only') | ||
.toString() | ||
.trim() | ||
.split('\n') | ||
.filter(file => { | ||
return /^src\/\S*\.[j|t]s$/.test(file) | ||
}) | ||
|
||
const result = spawnSync( | ||
'node', | ||
[ | ||
'./node_modules/eslint/bin/eslint.js', | ||
...modifiedList, | ||
'-c=./eslint/typescript.js', | ||
'--rulesdir=./eslint/rules', | ||
'--ignore-path=./.eslintignore' | ||
], | ||
{ | ||
stdio: 'inherit' | ||
} | ||
) | ||
|
||
process.exit(result.status) |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import pico from 'picocolors'; | ||
import { readFileSync } from 'node:fs'; | ||
import { resolve } from 'node:path'; | ||
|
||
const msgPath = resolve('.git/COMMIT_EDITMSG'); | ||
const msg = readFileSync(msgPath, 'utf-8').trim(); | ||
|
||
const commitRE = | ||
/^(Release v)|(Merge.*branch)|((revert: )?(feat|fix|docs|dx|style|refactor|perf|test|workflow|build|ci|chore|types|wip|release|version)(\(.+\))?: .+)/; | ||
|
||
if (!commitRE.test(msg)) { | ||
console.error( | ||
`\n ${pico.white(pico.bgRed(' ERROR '))} ${pico.red( | ||
`invalid commit message format.`, | ||
)}\n\n` + | ||
pico.red( | ||
` Proper commit message format is required for automated changelog generation. Examples:\n\n`, | ||
) + | ||
` ${pico.green(`feat(avformat): add 'IMp4Format' feature`)}\n` + | ||
` ${pico.green( | ||
`fix(avcodec): when stop reset subTaskId and subtitleTaskId (close #00)`, | ||
)}\n\n` + | ||
pico.red(` See .github/commit-convention.md for more details.\n`), | ||
); | ||
process.exit(1); | ||
} |
Submodule cheap
updated
3 files
+1 −1 | build/transformer.js | |
+1 −1 | thread/runThread.ts | |
+12 −0 | transformer/index.ts |