forked from envoyproxy/gateway
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from envoyproxy:main #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 63.33% 67.40% +4.06%
==========================================
Files 119 183 +64
Lines 19211 22442 +3231
==========================================
+ Hits 12168 15126 +2958
+ Misses 6244 6227 -17
- Partials 799 1089 +290 ☔ View full report in Codecov by Sentry. |
* Adding extension server policy handling. Signed-off-by: Lior Okman <lior.okman@sap.com> * added missing license header Signed-off-by: Lior Okman <lior.okman@sap.com> * Make the linter happy Signed-off-by: Lior Okman <lior.okman@sap.com> * Make spell-checking linter satisfied Signed-off-by: Lior Okman <lior.okman@sap.com> * Added some clarifying comments, fixed watchable key deletion in the runner Signed-off-by: Lior Okman <lior.okman@sap.com> * Added tests Signed-off-by: Lior Okman <lior.okman@sap.com> * Add tests Signed-off-by: Lior Okman <lior.okman@sap.com> * Finishing the rebase to the latest main. Signed-off-by: Lior Okman <lior.okman@sap.com> * Added an XDS level unit test. Signed-off-by: Lior Okman <lior.okman@sap.com> * Made the GCI linter happy Signed-off-by: Lior Okman <lior.okman@sap.com> * Some more unit tests. Signed-off-by: Lior Okman <lior.okman@sap.com> * Resolved comments provided in the review. Signed-off-by: Lior Okman <lior.okman@sap.com> * Regenerate deepcopies. Signed-off-by: Lior Okman <lior.okman@sap.com> * Removed the logger from the Translator type. Signed-off-by: Lior Okman <lior.okman@sap.com> * Only start the status updater for extension server policies if there is an extension server configured. Signed-off-by: Lior Okman <lior.okman@sap.com> * Changed the Translate function signature to return an error, and log any returned errors in the runner. Signed-off-by: Lior Okman <lior.okman@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com>
…ger gRPC server buffer (#3512) Reduce the amount of memory used by the in-memory gRPC buffer to a reasonable size. Signed-off-by: Lior Okman <lior.okman@sap.com>
* add more oidc configuration settings Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * add more comments Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * add more comments Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * address comments Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * change naming Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * change naming Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * fix gen check Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * change naming Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: huabing zhao <zhaohuabing@gmail.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
* api: cookie based consistent hashing Relates to #2624 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * tests Signed-off-by: Arko Dasgupta <arko@tetrate.io> * lint Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io>
…3418) * add generate API process with zh content update Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * keep all same as en Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * make all api gen work automatically Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * revert because ci not support sed Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * Fix all Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * add helm doc update for zh content Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * add comment for zh content update Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * up the zh api doc to date Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * sync latest update from #3492 Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * update the latest api doc Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * fix broken link Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * fix typo Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> * up api gen to date Signed-off-by: Wilson Wu <iwilsonwu@gmail.com> --------- Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
add test to codecov ignore path Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.6 to 3.25.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@9fdb3e4...f079b84) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ools/src/buf (#3517) build(deps): bump github.com/bufbuild/buf in /tools/src/buf Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.32.1 to 1.32.2. - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.32.1...v1.32.2) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.8 to 1.63.9. - [Release notes](https://github.com/fortio/fortio/releases) - [Commits](fortio/fortio@v1.63.8...v1.63.9) --- updated-dependencies: - dependency-name: fortio.org/fortio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@e92390c...0d4c9c5) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
implement additional OIDC configuration settings Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
* ensure that whenver client backend mtls secrets are updated, the latest secrets are used Signed-off-by: Alexander Volchok <alex.volchok@sap.com> * updating Signed-off-by: Alexander Volchok <alex.volchok@sap.com> --------- Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
#3524) * Add the listener name to each filter chain. Signed-off-by: Lior Okman <lior.okman@sap.com> * Update the egctl tests as well. Signed-off-by: Lior Okman <lior.okman@sap.com> * Also add the filterchain name from TCPRoutes Signed-off-by: Lior Okman <lior.okman@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com>
* Users prefer setting their own custom names for generated k8s resources for the Envoy Proxy fleet instead of the autogenerated resources * https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319 * knative-extensions/net-gateway-api#738 * #2141 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
…G control plane. (#3535) * Enable the configuration of topologySpreadConstraints for the EnvoyProxy control plane. * updating Signed-off-by: Alexander Volchok <alex.volchok@sap.com> --------- Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: zirain <zirain2009@gmail.com>
* implement backend Signed-off-by: Guy Daich <guy.daich@sap.com> * fix code review comments Signed-off-by: Guy Daich <guy.daich@sap.com> * code review fixes Signed-off-by: Guy Daich <guy.daich@sap.com>
* initial dashboard addon helm chart Signed-off-by: shawnh2 <shawnhxh@outlook.com> * rename addon name and remove gateway-helm support Signed-off-by: shawnh2 <shawnhxh@outlook.com> * remove /charts from .helmignore Signed-off-by: shawnh2 <shawnhxh@outlook.com> * rename to gateway-addons-helm and keep one source of truth Signed-off-by: shawnh2 <shawnhxh@outlook.com> * restore examples values and fix comments Signed-off-by: shawnh2 <shawnhxh@outlook.com> * rewrite helm makefile Signed-off-by: shawnh2 <shawnhxh@outlook.com> --------- Signed-off-by: shawnh2 <shawnhxh@outlook.com>
* fix: ReplaceFullPath not working for root path (/) Takes #2817 forward Signed-off-by: Arko Dasgupta <arko@tetrate.io>
remove redundant make helm-package command Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Kobi Levi <kobilevi503@gmail.com> Co-authored-by: zirain <zirain2009@gmail.com>
#3544) chore: Remove namespace restriction for EnvoyProxy parametersRef resource
* fix doc broken links Signed-off-by: Guy Daich <guy.daich@sap.com> * fix more links Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Update docs on gwapi support for backendref filters Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
* feat: support custom names for generated k8s resources Relates to #3527 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * use labels instead of name and ns to get deployment and svc Signed-off-by: Arko Dasgupta <arko@tetrate.io>
) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@fd25fed...595be6a) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
validateEndpointSliceForReconcile should check reference from EnvoyProxy Signed-off-by: zirain <zirain2009@gmail.com>
* add grafonnet lib and support for resources monitor dashboard Signed-off-by: shawnh2 <shawnhxh@outlook.com> * update helm-generate to support grafonnet generate dashboards Signed-off-by: shawnh2 <shawnhxh@outlook.com> * update doc Signed-off-by: shawnh2 <shawnhxh@outlook.com> * fix doc-lint and osv-scan Signed-off-by: shawnh2 <shawnhxh@outlook.com> * fix tools path Signed-off-by: shawnh2 <shawnhxh@outlook.com> * resolve conflicts Signed-off-by: shawnh2 <shawnhxh@outlook.com> * fix gen-check Signed-off-by: shawnh2 <shawnhxh@outlook.com> * fix doc-lint Signed-off-by: shawnh2 <shawnhxh@outlook.com> --------- Signed-off-by: shawnh2 <shawnhxh@outlook.com> Co-authored-by: Xunzhuo <bitliu@tencent.com>
* This ensures the readinessProbe kicks in only after the container has started * max startup time is 300s - 30 (failureThreshold) x 10 (periodSeconds). After this the container is killed and the `restartPolicy` kicks in https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#startup-probe Fixes: #3511 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: zirain <zirain2009@gmail.com>
* e2e: make sure OTel-collector is ready Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> * fix retry Signed-off-by: zirain <zirain2009@gmail.com> * remove infrastructure.parametersRef from all-namespace Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> * fix bad request Signed-off-by: zirain <zirain2009@gmail.com> * increase time of one cycle Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>
add load balancing usage Signed-off-by: shawnh2 <shawnhxh@outlook.com> Co-authored-by: Xunzhuo <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
…ors without explicit targetRefs (#3904) Fix the CEL definitions to allow policies that use target selectors without explicit targetRefs Signed-off-by: Lior Okman <lior.okman@sap.com>
Add tlog.Logf() logger Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
* e2e: refactor and improve lb test Signed-off-by: zirain <zirain2009@gmail.com> * tlog Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> * nit Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
* release v1.1.0 Signed-off-by: Guy Daich <guy.daich@sap.com> * update release notes with delta from v1.1.0-rc.1 Signed-off-by: Guy Daich <guy.daich@sap.com> * fix lint Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com>
…to 0.20.1 (#3924) build(deps): bump github.com/google/go-containerregistry Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.19.2 to 0.20.1. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.19.2...v0.20.1) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <zirain2009@gmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.12 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4fa2a79...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.0.6 to 2.0.8. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@a74c6b7...c062e08) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Bumps [fortio.org/log](https://github.com/fortio/log) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/fortio/log/releases) - [Commits](fortio/log@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: fortio.org/log dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xunzhuo <bitliu@tencent.com>
…20240707233129-f5f02f5a807c to 0.95.1 (#3925) build(deps): bump github.com/replicatedhq/troubleshoot Bumps [github.com/replicatedhq/troubleshoot](https://github.com/replicatedhq/troubleshoot) from 0.95.1-0.20240707233129-f5f02f5a807c to 0.95.1. - [Release notes](https://github.com/replicatedhq/troubleshoot/releases) - [Commits](https://github.com/replicatedhq/troubleshoot/commits/v0.95.1) --- updated-dependencies: - dependency-name: github.com/replicatedhq/troubleshoot dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <zirain2009@gmail.com> Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
* utilize hugo boilerplates for docs Signed-off-by: shawnh2 <shawnhxh@outlook.com> * fix doc-lint Signed-off-by: shawnh2 <shawnhxh@outlook.com> * fix boilerplates link Signed-off-by: shawnh2 <shawnhxh@outlook.com> --------- Signed-off-by: shawnh2 <shawnhxh@outlook.com> Co-authored-by: zirain <zirain2009@gmail.com>
* docs: add helm-version shortcode Signed-off-by: zirain <zirain2009@gmail.com> * update v1.1 and release doc Signed-off-by: zirain <zirain2009@gmail.com> * fix yaml-version Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: bitliu <bitliu@tencent.com>
authorization api doc Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
* build(deps): bump the k8s-io group with 6 updates Bumps the k8s-io group with 6 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.30.2` | `0.30.3` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.30.2` | `0.30.3` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.30.2` | `0.30.3` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.30.2` | `0.30.3` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.30.2` | `0.30.3` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.30.2` | `0.30.3` | Updates `k8s.io/api` from 0.30.2 to 0.30.3 - [Commits](kubernetes/api@v0.30.2...v0.30.3) Updates `k8s.io/apiextensions-apiserver` from 0.30.2 to 0.30.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.30.2...v0.30.3) Updates `k8s.io/apimachinery` from 0.30.2 to 0.30.3 - [Commits](kubernetes/apimachinery@v0.30.2...v0.30.3) Updates `k8s.io/cli-runtime` from 0.30.2 to 0.30.3 - [Commits](kubernetes/cli-runtime@v0.30.2...v0.30.3) Updates `k8s.io/client-go` from 0.30.2 to 0.30.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.30.2...v0.30.3) Updates `k8s.io/kubectl` from 0.30.2 to 0.30.3 - [Commits](kubernetes/kubectl@v0.30.2...v0.30.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add new types to the EnvoyFilter type validation rule Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * clean up EnvoyFilter consts in the xds translator Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add missing envoy filter in the api doc Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix typo Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix v1.1 doc Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
* printing name of the target when a policy fails to attach Signed-off-by: Viktor Sadovnikov <vsadovnikov@epo.org> * printing name of the target when a policy fails to attach Signed-off-by: Viktor Sadovnikov <vsadovnikov@epo.org> * printing name of the target when a policy fails to attach Signed-off-by: Viktor Sadovnikov <vsadovnikov@epo.org> --------- Signed-off-by: Viktor Sadovnikov <vsadovnikov@epo.org>
Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: Xunzhuo <bitliu@tencent.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )