Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ending separator to the menu options #98

Merged

Conversation

Alberdi
Copy link
Contributor

@Alberdi Alberdi commented Aug 21, 2023

Before this PR:

|Home(H)|Network(N)|System(S)|Ets(E)|App(A)|Doc(D)|Plugin(P)Interval: 2000ms
plugin-bar-before

After this PR:

|Home(H)|Network(N)|System(S)|Ets(E)|App(A)|Doc(D)|Plugin(P)|Interval: 2000ms
plugin-bar-after

Also reworked the get_menu_title/2 function so it's easier to change, and fixed a minor issue where pressing the Ets menu button didn't highlight the bar as in the other cases.

From:
|Home(H)|Network(N)|System(S)|Ets(E)|App(A)|Doc(D)|Plugin(P)Interval: 2000ms
To:
|Home(H)|Network(N)|System(S)|Ets(E)|App(A)|Doc(D)|Plugin(P)|Interval: 2000ms

Also reworked the get_menu_title/2 function so it's easier to change.
@zhongwencool zhongwencool merged commit 8ecd48a into zhongwencool:master Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants