Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add winget-releaser #412

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

ottnorml
Copy link
Contributor

fix #269

Copy link
Contributor Author

@ottnorml ottnorml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the new publish-to-winget job depends on the publish job that only runs when there is a new version, I couldn't test my changes without releasing version 1.4.0.

.github/workflows/release-please.yml Outdated Show resolved Hide resolved
@ottnorml ottnorml marked this pull request as ready for review September 28, 2023 14:15
@ottnorml ottnorml changed the title ci: Add winget-releaser !DRAFT: ci: Add winget-releaser Sep 28, 2023
@roldanjr
Copy link
Member

Since the new publish-to-winget job depends on the publish job that only runs when there is a new version, I couldn't test my changes without releasing version 1.4.0.

We'll wait for other bug fixes for batch release. Thanks for your contribution @ottnorml 🙇🏼

@ottnorml
Copy link
Contributor Author

ottnorml commented Sep 29, 2023

Since the new publish-to-winget job depends on the publish job that only runs when there is a new version, I couldn't test my changes without releasing version 1.4.0.

We'll wait for other bug fixes for batch release. Thanks for your contribution @ottnorml 🙇🏼

Fortunately, I did find a way to test the new action, and I noticed a few bugs that should be fixed now. 😁💪

@ottnorml ottnorml changed the title !DRAFT: ci: Add winget-releaser ci: Add winget-releaser Sep 29, 2023
@ottnorml
Copy link
Contributor Author

I opened a new PR to add v1.3.0 and its new installers for arm64 and x64 (see microsoft/winget-pkgs#121172).

@roldanjr
Copy link
Member

roldanjr commented Oct 2, 2023

Hi @ottnorml should we wait for this to pass the remaining CI checks?
image

I don't have Windows installed right now, maybe you can request @sekwah41 to review and test it once the issue on the winget-pkgs has been resolved.

@ottnorml
Copy link
Contributor Author

ottnorml commented Oct 2, 2023

Hi @roldanjr,
I have asked for a retry of the security check. The fact that the old PR is not yet merged does not affect this PR, because the release job will create a new independent PR for the new version of Pomaz. So there is nothing that would block the merging of this PR. 😁

Copy link
Member

@roldanjr roldanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roldanjr roldanjr merged commit 69a137c into zidoro:master Oct 3, 2023
3 checks passed
@ottnorml ottnorml deleted the ci/winget-releaser branch October 3, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Done
Development

Successfully merging this pull request may close these issues.

Submit package to Windows Package Manager Repository
2 participants