Adjust system mode behavior for Acova (Zehnder) heaters #256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #256 +/- ##
==========================================
+ Coverage 96.31% 96.33% +0.01%
==========================================
Files 61 61
Lines 9368 9404 +36
==========================================
+ Hits 9023 9059 +36
Misses 345 345 ☔ View full report in Codecov by Sentry. |
gdoffe
force-pushed
the
add_acova_heaters
branch
8 times, most recently
from
d09b59f to
08d6e62
Compare
gdoffe
force-pushed
the
add_acova_heaters
branch
from
08d6e62 to
f54d13d
Compare
| @@ -589,6 +589,67 @@ class ZenWithinThermostat(Thermostat): | |||
| """Zen Within Thermostat implementation.""" | |||
|
|
|||
|
|
|||
| @MULTI_MATCH( | |||
| cluster_handler_names=CLUSTER_HANDLER_THERMOSTAT, | |||
| manufacturers={"ZEHNDER GROUP VAUX ANDIGNY "}, | |||
There was a problem hiding this comment.
Hi,
I just tested this branch on my Home Assistant.
Personally, my heater's manufacturer name does not include the trailing spaces. Maybe I have a more recent version, and ZEHNDER has fixed this typo?
I believe both manufacturer names, "ZEHNDER GROUP VAUX ANDIGNY " and "ZEHNDER GROUP VAUX ANDIGNY", exist on the market.
Therefore, I propose a PR to @gdoffe repository to allow support for both manufacturer names. I hope it will be accepted and reflected in this PR :)
Otherwise, I tested it on my side (with this minor change), and it works very well. The modes are correctly mapped thanks to @gdoffe work.
gdoffe
force-pushed
the
add_acova_heaters
branch
2 times, most recently
from
0f11292 to
6b4b750
Compare
|
Thanks to @mattheop for its review and fixes, it is squashed and pushed. |
|
@puddly does it seem ok for you ? Just tell me if I need to do other modifications. 🙏 |
This commit addresses an issue where SystemMode.AUTO for Acova (Zehnder) heaters behaves differently from the HA standard. For this manufacturer, SystemMode.AUTO allows control of the heater via Zigbee, while SystemMode.HEAT puts the heater in manual mode. As a result, the conversion tables in ZHA climate constants (HVACMode) are incorrect for this device. The mapping for SystemMode.AUTO has been updated to correspond to HVACMode.HEAT instead of HVACMode.HEAT_COOL. Signed-off-by: Gilles DOFFE <g.doffe@gmail.com> Co-authored-by: Matthéo PERELLE <mattheo.perelle@gmail.com>
Signed-off-by: Gilles DOFFE <g.doffe@gmail.com> Co-authored-by: Matthéo PERELLE <mattheo.perelle@gmail.com>
gdoffe
force-pushed
the
add_acova_heaters
branch
from
6b4b750 to
8c57023
Compare
This PR addresses an issue where SystemMode.AUTO for Acova (Zehnder) heaters behaves differently from the HA standard. For this manufacturer, SystemMode.AUTO allows control of the heater via Zigbee, while SystemMode.HEAT puts the heater in manual mode.
As a result, the conversion tables in ZHA climate constants (HVACMode) are incorrect for this device. The mapping for SystemMode.AUTO has been updated to correspond to HVACMode.HEAT instead of HVACMode.HEAT_COOL.
See zigpy/zha-device-handlers#2921