Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milvus] Support custom annotations in pod deployments #138

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

jubingc
Copy link
Contributor

@jubingc jubingc commented Oct 31, 2024

What this PR does / why we need it:

To support datadog container autodiscovery, we need annotations attached directly to pods. The existing helm chart only supports custom annotations attached to services.

https://docs.datadoghq.com/containers/kubernetes/prometheus/

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

Welcome @jubingc! It looks like this is your first PR to zilliztech/milvus-helm 🎉

@haorenfsa
Copy link
Collaborator

@jubingc Thank you for bringing this patch! Please sign of your commits before we could merge it. see: https://github.com/zilliztech/milvus-helm/pull/138/checks?check_run_id=32317349030

Signed-off-by: Jubing Chen <jubingc@nvidia.com>
Signed-off-by: Jubing Chen <jubingc@nvidia.com>
@jubingc
Copy link
Contributor Author

jubingc commented Oct 31, 2024

@jubingc Thank you for bringing this patch! Please sign of your commits before we could merge it. see: https://github.com/zilliztech/milvus-helm/pull/138/checks?check_run_id=32317349030

Thanks for the pointer. Commits have been signed off now.

@haorenfsa
Copy link
Collaborator

/lgtm

@haorenfsa
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, jubingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ac02990 into zilliztech:master Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants