-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[milvus] Support custom annotations in pod deployments #138
[milvus] Support custom annotations in pod deployments #138
Conversation
Welcome @jubingc! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
@jubingc Thank you for bringing this patch! Please sign of your commits before we could merge it. see: https://github.com/zilliztech/milvus-helm/pull/138/checks?check_run_id=32317349030 |
Signed-off-by: Jubing Chen <jubingc@nvidia.com>
Signed-off-by: Jubing Chen <jubingc@nvidia.com>
10188f8
to
c14e448
Compare
Thanks for the pointer. Commits have been signed off now. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, jubingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
To support datadog container autodiscovery, we need annotations attached directly to pods. The existing helm chart only supports custom annotations attached to services.
https://docs.datadoghq.com/containers/kubernetes/prometheus/
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)