Partial Implementation of Dark Mode #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I much appreciate you for working on this. You know, |
|
We saw that in the latter half of working on this and in fact thought the same. Though, we felt we wanted to complete this implementation as it utilised some ideas which we wanted to use in order to learn more about Rust. Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BusyMaestro and I have added css classes for a dark mode. There are references to them in the Jinja files, though more must be made. Theme.rs has an implementation of dark versions of the
:rootcolours. This is toggled via 'zine.toml' under the dark_mode Boolean in [theme]. Any questions, feel free to ask 👍