Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed silencer SBT plugin #1171

Merged
merged 6 commits into from
Apr 28, 2024
Merged

Conversation

tPl0ch
Copy link
Contributor

@tPl0ch tPl0ch commented May 23, 2023

The plugin is not necessary anymore since it was back-ported to all currently supported compiler versions. It also breaks when using this library with the 3.3.1-RC1 Scala version:

[error] -- Error: typesafe/shared/src/main/scala/zio/config/typesafe/TypesafeConfigSource.scala:15:0
[error] undefined: new com.github.ghik.silencer.silent # -1: TermRef(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class ghik)),object silencer),silent),<init>) at readTasty

I also added a few improvements in the build itself, and fixed a few tests.

@tPl0ch tPl0ch requested a review from a team as a code owner May 23, 2023 09:57
The plugin is not necessary anymore since it was back-ported to all currently
supported compiler versions. It also breaks when using this library with the
3.3.1-RC1 Scala version:

```
[error] -- Error: typesafe/shared/src/main/scala/zio/config/typesafe/TypesafeConfigSource.scala:15:0
[error] undefined: new com.github.ghik.silencer.silent # -1: TermRef(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class ghik)),object silencer),silent),<init>) at readTasty
```

I also added a few improvements in the build itself, and fixed a few tests.
@tPl0ch
Copy link
Contributor Author

tPl0ch commented May 23, 2023

@afsalthaj I guess this touches a lot of points of #1091

Will you be able to merge #1091 at some point? Then I'd rebase this branch against master again.

@afsalthaj
Copy link
Collaborator

@tPl0ch Yes, Il try to merge #1091 . This looks good, thanks

@olafmaurer
Copy link

Will a fix for this also be merged into a new zio-config 3 release? It would be nice to be able to use it with Scala 3.3.

@seakayone
Copy link

Nice.
For those who are interested: I found a workaround.
In order to use zio-config with scala 3.3.0 I added the silencer lib from scala 2.13 to the dependencies:
"com.github.ghik" % "silencer-lib_2.13.11" % "1.7.13"
this way sbt doc would pass.

@afsalthaj
Copy link
Collaborator

Apologies for the big delay here, as I completely missed out to follow up.

@afsalthaj afsalthaj merged commit a14d73b into zio:series/4.x Apr 28, 2024
26 checks passed
@khajavi
Copy link
Member

khajavi commented May 21, 2024

@afsalthaj I guess this touches a lot of points of #1091

Will you be able to merge #1091 at some point? Then I'd rebase this branch against master again.

Can you help me on updating #1091 with the latest changes?

@khajavi
Copy link
Member

khajavi commented May 22, 2024

@tPl0ch I Forgot to ping you, on the previous comment. Need your help, if you have free time!

seakayone added a commit to dasch-swiss/dsp-ingest that referenced this pull request Jun 19, 2024
seakayone added a commit to dasch-swiss/dsp-ingest that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants