-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed silencer SBT plugin #1171
Conversation
The plugin is not necessary anymore since it was back-ported to all currently supported compiler versions. It also breaks when using this library with the 3.3.1-RC1 Scala version: ``` [error] -- Error: typesafe/shared/src/main/scala/zio/config/typesafe/TypesafeConfigSource.scala:15:0 [error] undefined: new com.github.ghik.silencer.silent # -1: TermRef(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class ghik)),object silencer),silent),<init>) at readTasty ``` I also added a few improvements in the build itself, and fixed a few tests.
7d25523
to
39a5f0f
Compare
@afsalthaj I guess this touches a lot of points of #1091 Will you be able to merge #1091 at some point? Then I'd rebase this branch against master again. |
Will a fix for this also be merged into a new zio-config 3 release? It would be nice to be able to use it with Scala 3.3. |
Nice. |
Apologies for the big delay here, as I completely missed out to follow up. |
Can you help me on updating #1091 with the latest changes? |
@tPl0ch I Forgot to ping you, on the previous comment. Need your help, if you have free time! |
zio/zio-config#1171 was resolved
The plugin is not necessary anymore since it was back-ported to all currently supported compiler versions. It also breaks when using this library with the 3.3.1-RC1 Scala version:
I also added a few improvements in the build itself, and fixed a few tests.