Replace @enumOfCaseObject with @simpleEnum #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouzen
commented
Nov 14, 2023
| @@ -284,35 +284,20 @@ object ItemDecoderSpec extends ZIOSpecDefault with CodecTestFixtures { | |||
|
|
|||
| assert(actual)(isRight(equalTo(PreBilled(id = 1, s = "foobar")))) | |||
| }, | |||
| test("decodes case object only enum with @enumOfCaseObjects annotation and without @caseName annotation") { | |||
| test("decodes case object only enum with @simpleEnum annotation and without @caseName annotation") { | |||
There was a problem hiding this comment.
I'm not pretty sure if we need to keep these test cases as it seems they test what was tested by zio-schema.
grouzen
commented
Nov 15, 2023
Comment on lines
-301
to
-315
| test("fails decoding of enum with @enumOfCaseObjects annotation that does not have all case objects") { | ||
| val item: Item = Item(Map("enum" -> AttributeValue.String("ONE"))) | ||
|
|
||
| val actual = DynamoDBQuery.fromItem[WithCaseObjectOnlyEnum2](item) | ||
|
|
||
| assert(actual)( | ||
| isLeft( | ||
| hasMessage( | ||
| equalTo( | ||
| "Can not decode enum String(ONE) - @enumOfCaseObjects annotation present when all instances are not case objects." | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| }, |
There was a problem hiding this comment.
Using @simpleEnum checks this in compile time.
grouzen
commented
Nov 15, 2023
Comment on lines
-236
to
-250
| test("fails encoding of enum with @enumOfCaseObjects annotation that does not have all case objects") { | ||
|
|
||
| val item = Try(DynamoDBQuery.toItem(WithCaseObjectOnlyEnum2(WithCaseObjectOnlyEnum2.ONE))) | ||
|
|
||
| assert(item)( | ||
| isFailure( | ||
| hasMessage( | ||
| equalTo( | ||
| "Can not encode enum ONE - @enumOfCaseObjects annotation present when all instances are not case objects." | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| }, | ||
| test("encodes enum and honours @caseName annotation when there is no @enumOfCaseObjects annotation") { |
There was a problem hiding this comment.
Using @simpleEnum checks this in compile time.
googley42
approved these changes
Nov 22, 2023
googley42
pushed a commit
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #284