Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a typed ProjectionExpression constructor #489

Conversation

pomadchin
Copy link
Contributor

@pomadchin pomadchin commented Sep 11, 2024

This PR adds an extra ProjectionExpression constructor with a type parameter.

Let me know what you think about it! I know that it's a low-level API and we probably can't encourage users using it, but it can be really useful sometimes to hide some dirt under the table.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@pomadchin
Copy link
Contributor Author

BTW I noticed that https://github.com/zio/zio-dynamodb/tree/series/2.x/.idea is commited into the repo! Is it intended? (it def conflicts with my local settings and locally idea overwrites it)

@pomadchin pomadchin force-pushed the feature/projection-expression-typed-constructor branch from d598384 to c7be881 Compare September 11, 2024 21:44
@googley42
Copy link
Contributor

googley42 commented Sep 13, 2024

So re $$ proposal - I think I would prefer the existing clean separation of High level and low level APIs - for instance in the High level API the use of .unsafeTo is actually "safe" in the scope of a ZIO Schema derived from the trait/case class - but is literally unsafe here for $$ as the field name and type are associated by hand

@googley42
Copy link
Contributor

closing for reason mentioned in comment

@googley42 googley42 closed this Sep 13, 2024
@googley42 googley42 reopened this Sep 30, 2024
@googley42
Copy link
Contributor

googley42 commented Sep 30, 2024

Re-opened as I can see this will be useful for defining ProjectExpressions for enums that are non root - ATM there is no high level API functionality to cover this.

@googley42 googley42 merged commit f04eff0 into zio:series/2.x Sep 30, 2024
28 checks passed
@pomadchin pomadchin deleted the feature/projection-expression-typed-constructor branch September 30, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants