Fix: Multipart Boundary Generation to Comply with RFC 2046 (#3123)

Co-authored-by: asr2003 <162500856+asr2003@users.noreply.github.com>
zio · Sep 11, 2024 · 39d7b93 · 39d7b93
1 parent 1f1c776
commit 39d7b93
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/zio-http/jvm/src/test/scala/zio/http/BoundarySpec.scala b/zio-http/jvm/src/test/scala/zio/http/BoundarySpec.scala
@@ -59,6 +59,17 @@ object BoundarySpec extends ZIOHttpSpec {
         boundary4.isEmpty,
       )
     },
+    suite("randomUUID")(
+      test("generated boundary is RFC 2046 compliant") {
+        for {
+          boundary <- Boundary.randomUUID
+        } yield assertTrue(
+          boundary.id.matches("^[a-zA-Z0-9-]+$"),
+          boundary.id.startsWith("----"),
+          boundary.id.endsWith("----"),
+        )
+      },
+    ),
   )
 
   val spec = suite("BoundarySpec")(

diff --git a/zio-http/shared/src/main/scala/zio/http/Boundary.scala b/zio-http/shared/src/main/scala/zio/http/Boundary.scala
@@ -75,6 +75,6 @@ object Boundary {
 
   def randomUUID(implicit trace: Trace): zio.UIO[Boundary] =
     zio.Random.nextUUID.map { id =>
-      Boundary(s"(((${id.toString()})))")
+      Boundary(s"----${id.toString}----")
     }
 }