-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Brotli as a compression option #2646
Comments
/bounty $75 |
💎 $75 bounty • ZIOSteps to solve:
Thank you for contributing to zio/zio-http! Add a bounty • Share on socials
|
@987Nabil , I haven't tried to run your PR locally, but it looks like you're trying to shade a native library. That will break the JNI binding and, AFAIK, the only way around that is to reimplement the JNI lib yourself. Why is the shading actually necessary here? This lib should probably be provided by the user anyway, since it's a native lib and needs to be built for the correct platform. In that case, you could probably get rid of the shading altogether, specify it as provided, and move on with your implementation. Do you intend to finish this? If not, I'm happy to take it over. |
@Andrapyre thanks for the input. I'll take care of it. |
💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
🎉🎈 @987Nabil has been awarded $75! 🎈🎊 |
Is your feature request related to a problem? Please describe.
Most browsers support brotli compression, which is a faster alternative to gzip. Netty already supports compressing payloads using brotli compression. It would be nice if zio-http exposed that as a compression option.
The main "issue" with adding this as an option is that this requires an additional dependency on
brotli4j
. While this could be added as an optional dependency (which is what Netty does), it might require adding some checks during the server initialization to ensure that the user has the dependency installed if they choose itDescribe the solution you'd like
Having
Brotli
as an additionalCompressionType
optionDescribe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: