Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brotli compression (#2646) #2673

Closed
wants to merge 1 commit into from
Closed

Add brotli compression (#2646) #2673

wants to merge 1 commit into from

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented Feb 8, 2024

@jdegoes I think the brotli4j dependency is okay. It would go to the netty backend module once we split zio-http core and netty backend.

fixes #2646
/claim #2646

@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (21989c9) 64.55% compared to head (838430c) 64.44%.

Files Patch % Lines
...o-http/shared/src/main/scala/zio/http/Server.scala 35.71% 9 Missing ⚠️
.../main/scala/zio/http/netty/model/Conversions.scala 28.57% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
- Coverage   64.55%   64.44%   -0.11%     
==========================================
  Files         145      145              
  Lines        8607     8620      +13     
  Branches     1521     1532      +11     
==========================================
- Hits         5556     5555       -1     
- Misses       3051     3065      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@987Nabil
Copy link
Contributor Author

987Nabil commented Feb 9, 2024

@jdegoes I am not sure what the problem with the shading is. Never had to configure it before. Can you give me a hint? The build error is not very helpful.

@jdegoes
Copy link
Member

jdegoes commented Feb 14, 2024

@987Nabil I have not used that setting before, I just know why it's used and how it works.

@jdegoes
Copy link
Member

jdegoes commented Apr 16, 2024

@987Nabil Please re-open when build is passing. 🙏

@jdegoes jdegoes closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Brotli as a compression option
3 participants