Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with websocket send #2341

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Fix issue with websocket send #2341

merged 2 commits into from
Jul 28, 2023

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Jul 28, 2023

Resolves #2275
/claim #2275

@github-actions github-actions bot added the bug Something isn't working label Jul 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.03% ⚠️

Comparison is base (3f1fb27) 63.17% compared to head (ff90c68) 63.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
- Coverage   63.17%   63.14%   -0.03%     
==========================================
  Files         135      135              
  Lines        7038     7039       +1     
  Branches     1224     1261      +37     
==========================================
- Hits         4446     4445       -1     
- Misses       2592     2594       +2     
Files Changed Coverage Δ
...ttp/src/main/scala/zio/http/WebSocketChannel.scala 23.80% <0.00%> (-6.20%) ⬇️
...p/src/main/scala/zio/http/netty/NettyChannel.scala 61.53% <100.00%> (ø)
...ain/scala/zio/http/netty/NettyFutureExecutor.scala 85.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit f36a8ca into main Jul 28, 2023
25 checks passed
@jdegoes jdegoes deleted the fix-2275 branch July 28, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web socket example throws error
3 participants