Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: compare jmh benchmarks #2751

Closed
wants to merge 46 commits into from

Conversation

alankritdabral
Copy link
Contributor

@alankritdabral alankritdabral commented Mar 29, 2024

@jdegoes This is a follow-up pr of #2750.
This pr compares the jmh benchmarks and fails the ci if any benchmarks exceeds a threshold of 10%.
Example of the failing workflow result

Issue Reference(s):
Relates to: #2750
Completes: #2265
/claim #2265

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.39%. Comparing base (2591f9f) to head (dbe342a).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
- Coverage   64.41%   64.39%   -0.03%     
==========================================
  Files         148      148              
  Lines        8669     8669              
  Branches     1545     1545              
==========================================
- Hits         5584     5582       -2     
- Misses       3085     3087       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alankritdabral alankritdabral marked this pull request as ready for review April 5, 2024 15:26
@alankritdabral
Copy link
Contributor Author

@jdegoes can you review this pr . 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants