-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags for OpenAPI endpoints #2792
Conversation
9da54ec
to
46218cb
Compare
46218cb
to
67e3df2
Compare
I would have a preference to incorporate the concept of a tag in @987Nabil Any objections to that approach? |
@jdegoes what I do not like about this is, that currently a doc is very explicitly instructions to render a doc. Tags would not be a part of the doc string generated for a path variable, for example. The concept of a tag exist only on the level of the endpoint. So I think this should be the only way it can be modeled. We could have a class that contains docs and tag and maybe more thing in the future (authentication requirements?) in the param of endpoint that is currently |
I just checked again for smithy. There it seems data structures can have tags too. But maybe such tags should go to the schema? 🤔 |
It also seems that tags can be more than just strings and have optional attributes according to OpenAPI specification |
@987Nabil I was thinking something like |
@YassineMEJRI lets give @jdegoes idea a try. Let's see how it looks like |
@YassineMEJRI Please re-open when you get a chance to fix the build! 🙏 |
Resolves #2716