Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zio schema version and add CurrencyType handling. #2864

Closed
wants to merge 11 commits into from

Conversation

russwyte
Copy link
Contributor

@russwyte russwyte commented May 25, 2024

Bumps zio-schema version to latest.
Fixes #2766

Note - I needed to handle new StandardType.CurrencyType - please check that I did it correctly. 😅

@russwyte russwyte changed the title Update zio schema version Update zio schema version and add CurrencyType handling. May 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.50%. Comparing base (3310828) to head (0ae73c7).
Report is 8 commits behind head on main.

Files Patch % Lines
...cala/zio/http/codec/internal/TextBinaryCodec.scala 0.00% 3 Missing ⚠️
...n/scala/zio/http/endpoint/openapi/JsonSchema.scala 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   64.64%   64.50%   -0.14%     
==========================================
  Files         156      156              
  Lines        9113     9143      +30     
  Branches     1584     1599      +15     
==========================================
+ Hits         5891     5898       +7     
- Misses       3222     3245      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@russwyte russwyte closed this May 28, 2024
@russwyte
Copy link
Contributor Author

Fixed in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoints from cases classes where the last field is an Option[Int] or Option[Long] result in BadRequest
2 participants