-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes the default Endpoint.outStream[X] encoding to produce a JSON array #3122
Conversation
…the MIME type `application/json` so that is produces a valid JSON array. Before it would simply produce concatenated JSON representations of the elements. For numeric `X` the response would not be parsable.
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
==========================================
- Coverage 65.66% 65.29% -0.38%
==========================================
Files 157 161 +4
Lines 10266 10629 +363
Branches 1929 2004 +75
==========================================
+ Hits 6741 6940 +199
- Misses 3525 3689 +164 ☔ View full report in Codecov by Sentry. |
…` for the MIME type `application/json` to JSON array reflected in the generated OpenAPI.
Now the OpenAPI generation is done. I hope I have implemented all the needed changes and tests. There are two small things that could improve this in my opinion:
It will also mitigate the codeconv-commenter complaint, as in |
@gregor-rayman please use the snapshot build of zip schema and make the simplifications you mentioned. If it works, I'll release zio-schema and we can use the released version before merging your pr. |
…r the JsonCodec.Config.treatStreamsAsArrays
@987Nabil , done. |
Optimize for request happy path
…the MIME type `application/json` so that is produces a valid JSON array. Before it would simply produce concatenated JSON representations of the elements. For numeric `X` the response would not be parsable.
…` for the MIME type `application/json` to JSON array reflected in the generated OpenAPI.
…r the JsonCodec.Config.treatStreamsAsArrays
@987Nabil , I have upgraded the |
Changes the default response encoding of
Endpoint.outStream[X]
for the MIME typeapplication/json
so that is produces a valid JSON array instead of just concatenated JSON entities.Fixes #3113, /claim #3113