[gen] verify issue #3077 is fixed #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een fixed in another commit
jdegoes
approved these changes
Sep 27, 2024
|
So you actually fixed it before? Or someone else? |
…t-rendered-bugfix
jdegoes
approved these changes
Sep 27, 2024
I'm not sure where exactly was the problem. Figured it would be easiest to just write the should-be-failing test, and debug it ¯\_(ツ)_/¯ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #3077
I wanted to fix this issue I had with pre-3.0.0 version.
Added a test that has previously failed.
and it passed…
Issue has already been fixed in another PR.
@jdegoes / @987Nabil I will not claim the bounty, as I did not do any fixing here.
But the issue can be closed now :)